Move actions out of 'actions' folder - #747
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The new sequester action code introduces at least one compile-breaking switch pattern and a few correctness/operational issues that should be fixed before merging.
Pull request overview
This PR restructures the repository by relocating the sequester GitHub Action into .github/actions/sequester (aligning with GitHub’s expected local-action layout) and removing several legacy actions that have been migrated to dotnet/docs-actions, reducing the maintenance surface of dotnet/docs-tools.
Changes:
- Moved the sequester action into
.github/actions/sequesterand updated Docker/action paths accordingly. - Removed multiple deprecated actions (and related workflows/tests) that have been moved out to
dotnet/docs-actions. - Updated repository metadata (README, solution contents, CODEOWNERS, workflows) to reflect the new scope.
File summaries
| File | Description |
|---|---|
| sequester.Dockerfile | Update build path to new sequester action location under .github/actions. |
| README.md | Re-scope README to sequester + point to dotnet/docs-actions for other actions. |
| docs-tools.sln | Remove projects/workflows that were moved out; solution cleanup. |
| actions/status-checker/tsconfig.json | Removed (action migrated out). |
| actions/status-checker/src/wait.ts | Removed (action migrated out). |
| actions/status-checker/src/types/WorkflowInput.ts | Removed (action migrated out). |
| actions/status-checker/src/status-checker.ts | Removed (action migrated out). |
| actions/status-checker/src/main.ts | Removed (action migrated out). |
| actions/status-checker/README.md | Removed (action migrated out). |
| actions/status-checker/package.json | Removed (action migrated out). |
| actions/status-checker/jest.config.js | Removed (action migrated out). |
| actions/status-checker/action.yml | Removed (action migrated out). |
| actions/status-checker/.prettierignore | Removed (action migrated out). |
| actions/status-checker/.gitignore | Removed (action migrated out). |
| actions/status-checker/.gitattributes | Removed (action migrated out). |
| actions/status-checker/.eslintrc.json | Removed (action migrated out). |
| actions/status-checker/.eslintignore | Removed (action migrated out). |
| actions/status-checker/tests/main.test.ts | Removed (action migrated out). |
| actions/sequester/.dockerignore | Removed from old location (moved to .github/actions/sequester). |
| actions/ops-build-reporter/tsconfig.json | Removed (action migrated out). |
| actions/ops-build-reporter/src/types/WorkflowInput.ts | Removed (action migrated out). |
| actions/ops-build-reporter/src/types/PullRequestDetails.ts | Removed (action migrated out). |
| actions/ops-build-reporter/src/main.ts | Removed (action migrated out). |
| actions/ops-build-reporter/README.md | Removed (action migrated out). |
| actions/ops-build-reporter/package.json | Removed (action migrated out). |
| actions/ops-build-reporter/jest.config.js | Removed (action migrated out). |
| actions/ops-build-reporter/action.yml | Removed (action migrated out). |
| actions/ops-build-reporter/.prettierignore | Removed (action migrated out). |
| actions/ops-build-reporter/.gitignore | Removed (action migrated out). |
| actions/ops-build-reporter/.gitattributes | Removed (action migrated out). |
| actions/ops-build-reporter/.eslintrc.json | Removed (action migrated out). |
| actions/ops-build-reporter/.eslintignore | Removed (action migrated out). |
| actions/ops-build-reporter/tests/pull-updater.test.ts | Removed (action migrated out). |
| actions/dotnet-version-updater/upgrade-projects.ps1 | Removed (action migrated out). |
| actions/dotnet-version-updater/action.yml | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/README.md | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/MSDocsSpecific/Includes2/includes/dotnetclitoolreference.md | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/MSDocsSpecific/Includes2/core/tools/sdk-errors/netsdk1059.md | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/MSDocsSpecific/Includes2/core/compatibility/2.1.md | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/MSDocsSpecific/Includes/include.md | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/MSDocsSpecific/Includes/aspnetcore.md | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/MarkdownLinksVerifier/test1/folder/Name With Space.md | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/MarkdownLinksVerifier/test1/File1.md | Removed (action migrated out). |
| actions/docs-verifier/valid-test-cases/MarkdownLinksVerifier/test-query-parameters/File.md | Removed (action migrated out). |
| actions/docs-verifier/tests/MarkdownLinksVerifier/MarkdownLinksVerifier.UnitTests.csproj | Removed (action migrated out). |
| actions/docs-verifier/tests/MarkdownLinksVerifier/LinkValidatorTests/Utilities/Workspace.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/MarkdownLinksVerifier/LinkValidatorTests/Utilities/FilesCollection.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/MarkdownLinksVerifier/LinkValidatorTests/MailtoLinkValidatorTests.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/MarkdownLinksVerifier/LinkValidatorTests/LocalLinkValidatorTests.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/MarkdownLinksVerifier/LinkClassifierTests.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/MarkdownLinksVerifier/GlobalSuppressions.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/MarkdownLinksVerifier/ConfigurationTests/ConfigurationReaderTests.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/GitHub.UnitTests/RedirectTargetVerifierTests.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/GitHub.UnitTests/PullRequestFileExtensionsTests.cs | Removed (action migrated out). |
| actions/docs-verifier/tests/GitHub.UnitTests/GitHub.UnitTests.csproj | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/RedirectTargetVerifier.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/RedirectionVerifier.csproj | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/RedirectionsVerifier.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/RedirectionHelpers.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/Redirection.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/Properties/AssemblyInfo.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/OpenPublishingRedirections.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/OpenPublishingRedirectionReader.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/OpenPublishingConfigReader.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/OpenPublishingConfig.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/DocfxConfigurationReader.cs | Removed (action migrated out). |
| actions/docs-verifier/src/RedirectionVerifier/DocfxConfiguration.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/MarkdownLinksVerifier.csproj | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/MarkdownFilesAnalyzer.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/LinkValidator/ValidationResult.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/LinkValidator/OnlineLinkValidator.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/LinkValidator/MailtoLinkValidator.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/LinkValidator/LocalLinkValidator.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/LinkValidator/LinkValidatorCreator.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/LinkValidator/ILinkValidator.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/LinkClassifier/LinkClassification.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/LinkClassifier/Classifier.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/Configuration/MarkdownLinksVerifierConfiguration.cs | Removed (action migrated out). |
| actions/docs-verifier/src/MarkdownLinksVerifier/Configuration/ConfigurationReader.cs | Removed (action migrated out). |
| actions/docs-verifier/src/GitHub/PullRequestFileExtensions.cs | Removed (action migrated out). |
| actions/docs-verifier/src/GitHub/GitHubPullRequest.cs | Removed (action migrated out). |
| actions/docs-verifier/src/GitHub/GitHub.csproj | Removed (action migrated out). |
| actions/docs-verifier/src/DocfxVerifier/DocfxVerifier.csproj | Removed (action migrated out). |
| actions/docs-verifier/src/BuildVerifier.IO.Abstractions/BuildVerifier.IO.Abstractions.csproj | Removed (action migrated out). |
| actions/docs-verifier/src/BuildVerifier.IO.Abstractions/BaseMappedConfigurationReader.cs | Removed (action migrated out). |
| actions/docs-verifier/src/BuildVerifier.IO.Abstractions/BaseConfigurationReader.cs | Removed (action migrated out). |
| actions/docs-verifier/src/ActionRunner/Program.cs | Removed (action migrated out). |
| actions/docs-verifier/src/ActionRunner/ActionRunner.csproj | Removed (action migrated out). |
| actions/docs-verifier/README.md | Removed (action migrated out). |
| actions/docs-verifier/nuget.config | Removed (action migrated out). |
| actions/docs-verifier/eng/Settings.props | Removed (action migrated out). |
| actions/docs-verifier/docs/json-config-file.md | Removed (action migrated out). |
| actions/docs-verifier/Dockerfile | Removed (action migrated out). |
| actions/docs-verifier/Directory.Build.props | Removed (action migrated out). |
| actions/docs-verifier/action.yml | Removed (action migrated out). |
| actions/docs-verifier/.gitignore | Removed (action migrated out). |
| actions/docs-verifier/.editorconfig | Removed (action migrated out). |
| actions/dependabot-bot/src/dependabot-bot/Program.Services.cs | Removed (action migrated out). |
| actions/dependabot-bot/src/dependabot-bot/Program.Regex.cs | Removed (action migrated out). |
| actions/dependabot-bot/src/dependabot-bot/Program.cs | Removed (action migrated out). |
| actions/dependabot-bot/src/dependabot-bot/GlobalUsings.cs | Removed (action migrated out). |
| actions/dependabot-bot/src/dependabot-bot/Extensions/StringBuilderExtensions.cs | Removed (action migrated out). |
| actions/dependabot-bot/src/dependabot-bot/Dockerfile | Removed (action migrated out). |
| actions/dependabot-bot/src/dependabot-bot/dependabot-bot.csproj | Removed (action migrated out). |
| actions/dependabot-bot/README.md | Removed (action migrated out). |
| actions/dependabot-bot/dependabot-bot.sln | Removed (action migrated out). |
| actions/dependabot-bot/action.yml | Removed (action migrated out). |
| actions/dependabot-bot/.gitignore | Removed (action migrated out). |
| .github/workflows/quest.yml | Minor whitespace cleanup. |
| .github/workflows/node-build-validation.yml | Removed (workflow tied to removed TS action). |
| .github/workflows/dotnet-build-validation.yml | Stop ignoring removed status-checker paths. |
| .github/workflows/build-docs-verifier.yml | Removed (workflow tied to removed docs-verifier action). |
| .github/CODEOWNERS | Update ownership entries to new sequester action location. |
| .github/actions/sequester/Quest2GitHub/Quest2GitHub.csproj | Update project reference path due to new directory depth. |
| .github/actions/sequester/Quest2GitHub/Options/RawGitHubFileReader.cs | Add GitHub raw-config reader for quest config. |
| .github/actions/sequester/Quest2GitHub/Options/LocalFileReader.cs | Add local-config reader for quest config. |
| .github/actions/sequester/Quest2GitHub/Options/ImportOptions.cs | Introduce consolidated import options model for sequester. |
| .github/actions/sequester/Quest2GitHub/Options/EnvironmentVariableReader.cs | Centralize env-var reading for API keys. |
| .github/actions/sequester/Quest2GitHub/Options/AzureDevOpsOptions.cs | Add Azure DevOps configuration model. |
| .github/actions/sequester/Quest2GitHub/Options/ApiKeys.cs | Add API keys configuration model (docs for env vars). |
| .github/actions/sequester/Quest2GitHub/Models/WorkItemProperties.cs | Add work item property derivation logic for Quest import. |
| .github/actions/sequester/Quest2GitHub/Models/QuestIteration.cs | Add iteration model and helpers. |
| .github/actions/sequester/Quest2GitHub/Models/IssueExtensions.cs | Add iteration selection helpers based on story points. |
| .github/actions/sequester/Quest2GitHub/GlobalUsings.cs | Add global usings for the sequester action code. |
| .github/actions/sequester/Quest2GitHub/Extensions/ServiceCollectionExtensions.cs | Add DI helper for binding ImportOptions. |
| .github/actions/sequester/Quest2GitHub/Extensions/ImportOptionsExtensions.cs | Add validation + safe console logging for options. |
| .github/actions/sequester/Quest2GitHub/AzDoClientServices/QuestClient.cs | Add Azure DevOps client implementation + retry policy. |
| .github/actions/sequester/Quest2GitHub/AzDoClientServices/JsonPatchDocument.cs | Add Azure DevOps JSON patch document models. |
| .github/actions/sequester/Quest2GitHub.Tests/RawGitHubFileReaderTests.cs | Add (currently stubbed) tests for raw GitHub config reading. |
| .github/actions/sequester/Quest2GitHub.Tests/QuestWorkItemTests.cs | Add tests for title truncation behavior. |
| .github/actions/sequester/Quest2GitHub.Tests/Quest2GitHub.Tests.csproj | Add test project for sequester action code. |
| .github/actions/sequester/Quest2GitHub.Tests/quest-import.json | Add test JSON config fixture. |
| .github/actions/sequester/Quest2GitHub.Tests/ImportOptionsTests.cs | Add tests for option defaults, binding, and validation. |
| .github/actions/sequester/Quest2GitHub.Tests/GlobalUsings.cs | Add global usings for tests. |
| .github/actions/sequester/Quest2GitHub.Tests/GetIterationTests.cs | Add tests for iteration lookup logic. |
| .github/actions/sequester/Quest2GitHub.sln | Update solution item paths due to new directory depth. |
| .github/actions/sequester/ImportIssues/Program.cs | Add new ImportIssues entrypoint + arg parsing + config loading. |
| .github/actions/sequester/ImportIssues/ImportIssues.csproj | Add ImportIssues project (new sequester action executable). |
| .github/actions/sequester/ImportIssues/GlobalUsings.cs | Add global usings for ImportIssues project. |
| .github/actions/sequester/action.yml | Update docker action path to sequester.Dockerfile at repo root. |
| .github/actions/sequester/.gitattributes | Add text normalization rules for the action directory. |
| .github/actions/sequester/.dockerignore | Add docker ignore rules in new action location. |
Review details
- Files reviewed: 121/163 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #743.