Rename oidc auth action - #751
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Both workflows contain invalid local action paths that will prevent authentication from loading.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Renames the Azure OIDC composite action to match Azure’s recommended naming.
Changes:
- Updates workflow references.
- Refreshes the action name and description.
File summaries
| File | Summary |
|---|---|
.github/workflows/quest.yml |
Uses the renamed action; local action references still require correction. |
.github/workflows/quest-bulk.yml |
Uses the renamed action; local action references still require correction. |
.github/actions/azure-oidc-auth/action.yml |
Updates action metadata. |
Review details
Suppressed comments (2)
.github/workflows/quest-bulk.yml:45
- This reference still starts with
$/.github, which GitHub Actions does not treat as a local action path; local actions must use the./.github/...form. The authentication step will fail to load until this is changed.
uses: $/.github/actions/azure-oidc-auth
.github/workflows/quest.yml:51
- This reference still starts with
$/.github, which GitHub Actions does not treat as a local action path; local actions must use the./.github/...form. The authentication step will fail to load until this is changed.
uses: $/.github/actions/azure-oidc-auth
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous folder name made it sound like a workflow, but it's actually a composite action. This is the name that Azure recommends.