Add ReasoningEffort.Max - #7717
Open
AkiKurisu wants to merge 1 commit into
Open
Conversation
Author
|
@dotnet-policy-service agree |
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Maxlevel toReasoningEffort, one tier aboveExtraHigh. Both providers withfirst-party
IChatClientadapters now expose it: OpenAI added"max"toResponseReasoningEffortLevelinopenai-dotnet#1289, and Anthropic
12.42.0 already exposes
MaxonAnthropic.Models.Messages.Effort. SinceReasoningOptionsis
sealedwith onlyEffortandOutput, there is currently no provider-neutral way torequest the top tier.
Implements the API proposed in #7715.
Changes
ReasoningEffort.cs: AddMax. Reword theExtraHighsummary, which claimed"Maximum reasoning for the most demanding tasks".
OpenAIChatClient.cs/OpenAIResponsesChatClient.cs: MapReasoningEffort.Maxto
new ChatReasoningEffortLevel("max")/new ResponseReasoningEffortLevel("max"),using the string constructor as
"xhigh"does today (Map ReasoningEffort.None and ExtraHigh to "none" and "xhigh" in OpenAI IChatClient implementations #7319). These can move to thegenerated
.Maxproperty once a release containing openai-dotnet#1289 is picked up.Microsoft.Extensions.AI.Abstractions.json: Add the new stable field to the APIbaseline.
Maxas[InlineData]on the existing parameterized theories inReasoningOptionsTests,OpenAIChatClientTests, andOpenAIResponseClientTests. Thelatter two assert the emitted
"max"wire value.Microsoft Reviewers: Open in CodeFlow