WIP - another take at resumable state-machine lowering in Debug - #20498
Draft
T-Gro wants to merge 6 commits into
Draft
WIP - another take at resumable state-machine lowering in Debug#20498T-Gro wants to merge 6 commits into
T-Gro wants to merge 6 commits into
Conversation
Keep resumable producers and template-hosting bodies on the compulsory inlining path. Avoid extracting Debug specializations involving state-machine templates: the generated struct can carry captured type parameters that the helper cannot preserve. Retain ordinary Debug calls, add runtime and cross-assembly regressions, and update affected IL expectations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use withOptimization instead of rebuilding compiler flags. Parameterize the captured-state-machine regression over Debug and optimized compilation without duplicating its source or adding lines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore full lowered Test fixtures instead of MoveNext-only fragments, preserving factory, state, accessor and helper checks. Keep source programs and compiler options unchanged. Clarify that the renamed mandatory-inlining cache retains frame-local behavior as well as resumable templates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
Warning No PR link found in some release notes, please consider adding it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft is to run CI on the proposed additions to @majocha's #20469. If CI passes, let's merge these changes into #20469 rather than merge this draft separately.