Conversation
Add the original request and one self-contained implementation sprint. Cover safe RED cases, all eleven getter bodies and twenty-one dimension counts, based-array boundaries, recompiled consumers, local validation, expert review, and release notes. Validated sprint structure, Markdown tables, repository paths, and getter inventory locally. Product implementation and tests remain sprint work; the pinned SDK was unavailable during planning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4a6e8d16-3869-4b65-aea1-634f25e2dbaf
Normalize retained getter dimensions with an inclusive upper bound and compare endpoints before subtracting. Preserve each retained axis, based indices, null exceptions and fixed-index validation timing. Leave setters, copy helpers, signatures and fixed-getter source offsets unchanged. Validation: - RED before product edits: 44/44 regression cases failed for netstandard2.0, netstandard2.1 and shipped net10.0 Core, plus the actual default test host. - GREEN: 44/44 passed for freshly compiled consumers of all three targets in Debug and Release, exercising slice syntax and callable intrinsic bodies. - Debug and Release composite builds passed with no warnings or errors. - Original siblings passed 33/33; broader slicing selection passed 127/127. - Full default Release Core suite: 6337 passed, 5 existing skips, 0 failures. Both surface-area checks passed without baseline changes. - Local expert review: LGTM, no actionable findings or new API dependencies. Consumers were recompiled against each local Core assembly. Replacing FSharp.Core alone does not repair arithmetic already inlined into old binaries. Commands, RED/GREEN results, references, identities and binlogs are retained in the ignored .tools/ralph/evidence/issue-20530 directory. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1025155-aaf9-4029-965e-790914c9bad7
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6fa70800-9879-48dc-b7c3-a195759cf4dd
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
Recover the test-only delta from 1afa05af5860496aa21e5611581406b0f8a0a634. Keep all supported Desktop rows and preserve the getter implementation. Both compressed Release SDK configurations pass Desktop/CoreCLR shape 38/39, getters 43/45, siblings 125/127, and full Core suites 6255/6337 with five existing skips each. Exact VS composite configurations remain pending on compatible infrastructure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8fdec442-2296-4dcd-b96f-f499a8485cdd
Keep working copies for the runner. Preserve plans and validation evidence outside the worktree. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8fdec442-2296-4dcd-b96f-f499a8485cdd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20530
Array and string slices with extreme reversed bounds now return empty results instead of throwing, including multidimensional and fixed-dimension array slices.