Skip to content

[wasm] Build a test-specific corerun for nine more runtime tests #133367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radekdoulik wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[wasm] Build a test-specific corerun for nine more runtime tests #133367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d59d805
[wasm] Build a test-specific corerun for nine more runtime tests
radekdoulik Sep 7, 2026
1562a37
Merge commit 'd47474c606c9af7f88a1e26b2ec8d0a5834286f0' into wasm-ena…
radekdoulik Sep 7, 2026
56570a0
[wasm] Gate Vector3 reverse P/Invoke on browser
radekdoulik Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/tests/Interop/StructMarshalling/PInvoke/NestedStruct.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- No test-specific corerun on wasm: the generator or the wasm linker rejects this test's
native interop surface. Native-dependent tests skip instead. Tracked by https://github.com/dotnet/runtime/issues/131811 -->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
<!-- Needed for CMakeProjectReference -->
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
3 changes: 0 additions & 3 deletions src/tests/JIT/Directed/StructABI/StructABI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- No test-specific corerun on wasm: the generator or the wasm linker rejects this test's
native interop surface. Native-dependent tests skip instead. Tracked by https://github.com/dotnet/runtime/issues/131811 -->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
<!-- Needed for CMakeProjectReference -->
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
3 changes: 0 additions & 3 deletions src/tests/JIT/Directed/callconv/CdeclMemberFunction/CdeclMemberFunctionTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- No test-specific corerun on wasm: the generator or the wasm linker rejects this test's
native interop surface. Native-dependent tests skip instead. Tracked by https://github.com/dotnet/runtime/issues/131811 -->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
<!-- Needed for CMakeProjectReference -->
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
3 changes: 0 additions & 3 deletions .../Directed/callconv/PlatformDefaultMemberFunction/PlatformDefaultMemberFunctionTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- No test-specific corerun on wasm: the generator or the wasm linker rejects this test's
native interop surface. Native-dependent tests skip instead. Tracked by https://github.com/dotnet/runtime/issues/131811 -->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
<!-- Needed for CMakeProjectReference -->
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
3 changes: 0 additions & 3 deletions src/tests/JIT/Directed/callconv/StdCallMemberFunction/StdCallMemberFunctionTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- No test-specific corerun on wasm: the generator or the wasm linker rejects this test's
native interop surface. Native-dependent tests skip instead. Tracked by https://github.com/dotnet/runtime/issues/131811 -->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
<!-- Needed for CMakeProjectReference -->
<RequiresProcessIsolation>true</RequiresProcessIsolation>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
3 changes: 0 additions & 3 deletions src/tests/JIT/Directed/callconv/ThisCall/ThisCallTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- No test-specific corerun on wasm: the generator or the wasm linker rejects this test's
native interop surface. Native-dependent tests skip instead. Tracked by https://github.com/dotnet/runtime/issues/131811 -->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
<MonoAotIncompatible>true</MonoAotIncompatible> <!-- https://github.com/dotnet/runtime/issues/90427 -->
<!-- Needed for CMakeProjectReference -->
<RequiresProcessIsolation>true</RequiresProcessIsolation>
Expand Down
8 changes: 0 additions & 8 deletions src/tests/JIT/Methodical/Methodical_others.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
<HasMergedInTests>true</HasMergedInTests>
<!-- Tracking issue: https://github.com/dotnet/runtime/issues/90427 -->
<CLRTestTargetUnsupported Condition="'$(RuntimeFlavor)' == 'mono' and ('$(RuntimeVariant)' == 'minifullaot' or '$(RuntimeVariant)' == 'llvmfullaot')">true</CLRTestTargetUnsupported>
<!--
The merged runner compiles reverse P/Invoke tests directly into its own assembly, so the
wasm P/Invoke table generator cannot emit call helpers for them and they cannot be excluded
one project at a time. Skip the test-specific corerun; the tests merged in here that need
native assets stay gated on TestLibrary.PlatformDetection.PlatformDoesNotSupportNativeTestAssets.
Tracked by https://github.com/dotnet/runtime/issues/131811
-->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
</PropertyGroup>
<ItemGroup>
<MergedWrapperProjectReference Include="*/**/*.??proj" />
Expand Down
3 changes: 0 additions & 3 deletions src/tests/JIT/SIMD/JIT.SIMD_r.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- No test-specific corerun on wasm: the generator or the wasm linker rejects this test's
native interop surface. Native-dependent tests skip instead. Tracked by https://github.com/dotnet/runtime/issues/131811 -->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
<DebugType>None</DebugType>
<Optimize />
<HasMergedInTests>true</HasMergedInTests>
Expand Down
3 changes: 0 additions & 3 deletions src/tests/JIT/SIMD/JIT.SIMD_ro.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<!-- No test-specific corerun on wasm: the generator or the wasm linker rejects this test's
native interop surface. Native-dependent tests skip instead. Tracked by https://github.com/dotnet/runtime/issues/131811 -->
<WasmBuildTestCorerun Condition="'$(RuntimeFlavor)' == 'coreclr' and '$(TargetOS)' == 'browser'">false</WasmBuildTestCorerun>
<DebugType>None</DebugType>
<Optimize>True</Optimize>
<HasMergedInTests>true</HasMergedInTests>
Expand Down
21 changes: 17 additions & 4 deletions src/tests/JIT/SIMD/Vector3Interop.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,16 +563,29 @@ public class Test_Vector3Interop
[Fact]
public static int TestEntryPoint()
{

if (!PInvokeTest.test())
{
return 101;
}

if (!RPInvokeTest.test())

return 100;
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/90427", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoLLVMFULLAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/90427", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoMINIFULLAOT))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/96051", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoInterpreter), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsOSX))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/92129", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/127827", typeof(TestLibrary.CoreClrConfigurationDetection), nameof(TestLibrary.CoreClrConfigurationDetection.IsGCStressC))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/123946", typeof(PlatformDetection), nameof(PlatformDetection.PlatformDoesNotSupportNativeTestAssets))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/131811", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]
[Fact]
public static int TestReversePInvoke()
{
if (!RPInvokeTest.test())
{
return 101;
}

return 100;
}
}
}