Trim ILTrim parameter names selectively - #134087
jtschuster wants to merge 1 commit into
Conversation
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
jtschuster
changed the title
|
Tagging subscribers to this area: @dotnet/crossgen-contrib |
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
jkotas
added
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
| // TODO: this should be a separate node with more logic | ||
| var definition = (EcmaMethod)method.GetTypicalMethodDefinition(); | ||
| _reflectedMethods.TryAdd(new HandleKey<MethodDefinitionHandle>(definition.Module, definition.Handle), 0); |
There was a problem hiding this comment.
I think we should just have a ReflectedMethodNode, same as ILC has. We'll probably need to condition things on such node later (for example, if an interface method is reflected, all the implementations of the interface method should also be considered reflected because one can just create a delegate to an interface method and then query its MethodInfo).
ParameterNode can then just query .IsMarked on the owning method ReflectedMethodNode.
There was a problem hiding this comment.
Mmm, looks like we lack API (equivalent of #60380) to get from parameter handle to method.
We can do something slow to workaround for now and file the issue to get an API.
939eedc to
79fd706
Compare
Squash accepted iteration-8 slot 3 from b41340e1cd422b268fcac0ecfa56430925516a08. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e06ebffa-ad53-49ba-b7aa-2efb4ee16d92
79fd706 to
2f633de
Compare
3 participants
The draft PRs in this stack I haven't reviewed myself and don't expect anyone else to until I mark them ready for review (unless you want to). If the tags are causing too much noise for anyone I can move them to my fork until their ready.
Layer 9 of 12 in the ILTrim expected-failure reduction stack.
Remove parameter names when they are not reflection-visible while retaining names required by reflected methods and descriptors.
Stack-top validation
./build.sh tools+tools.ilasm+tools.illinktests+tools.cdactests -testpassed with 0 warnings and 0 errors.Stack created with GitHub Stacks CLI • Give Feedback 💬
Note
This PR description was generated by GitHub Copilot.