Implement IParsable on Uri - #134112
Merged
Merged
Implement IParsable on Uri#134112
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Adds explicit IParsable<Uri> support using relative-or-absolute parsing with implicit file paths disabled.
Changes:
- Updates the public API and
Uriimplementation. - Adjusts parsing invariants.
- Adds parsing and file-path behavior tests.
File summaries
| File | Description |
|---|---|
src/libraries/System.Runtime/ref/System.Runtime.cs |
Adds the IParsable<Uri> API contract. |
src/libraries/System.Private.Uri/tests/FunctionalTests/UriCreationOptionsTest.cs |
Tests file-path behavior. |
src/libraries/System.Private.Uri/tests/FunctionalTests/UriCreateStringTests.cs |
Tests parsing scenarios and edge cases. |
src/libraries/System.Private.Uri/src/System/UriExt.cs |
Implements parsing behavior and updates invariants. |
src/libraries/System.Private.Uri/src/System/Uri.cs |
Declares Uri as implementing IParsable<Uri>. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
MihaZupan
enabled auto-merge (squash)
September 17, 2026 13:29
ManickaP
approved these changes
Sep 17, 2026
This was referenced Sep 18, 2026
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92285
As discussed on the API review issue, the methods are implemented explicitly, and the behavior is
UriKind.RelativeOrAbsolutewithAllowImplicitFilePaths = false.