Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15078 +/- ##
=============================================
Coverage 37.24166% 37.24166%
=============================================
Files 246 246
Lines 9774 9774
Branches 1029 1029
=============================================
Hits 3640 3640
Misses 5970 5970
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12319
Proposed changes
accessibility bounds: an empty rectangle for outside and a rectangle covering the
documented signed-16-bit virtual-screen coordinate range for inside. Neither value
depends on the current monitor arrangement or DPI.
ListViewItem.IKeyboardToolTip.IsHoveredWithMouseimplementation.Use the existing Moq protected-factory pattern to substitute only the accessibility
bounds, with normal ListView behavior retained via
CallBase.Keep the existing attached/detached and inside/outside cases. Verify that attached
items consult the bounds and that the test does not create a native control handle.
Customer Impact
from another test or process.
interactive cursor-positioning step.
Regression?
Risk
retries, skip conditions, or shared mutable state.
Real native accessibility geometry remains outside this test's scope.
Test methodology
main,8efd9a920dba90722f8db1f7e943f74837d26579.pl-PLanden-US, including the restored virtual-mode case.restored positive case fails, and the bounds-read check also detects the bypass
in the virtual-mode/outside case. Mutation removed before the final build/test.
structural guard found its two
Cursor.Positionwrites and passes after the fix;this is not a claim to reproduce the original intermittent CI failure.
avoid moving the cursor); patched 75 passed / 9 failed, with no exclusions or
skips. The same nine unchanged
ViewLargeIconneighboring-rectangle cases failbefore and after. Their layout assumptions are deliberately outside this PR.
git diff --checkpasses. The full repositorysuite was not run for this change.
Run the target from the built
System.Windows.Forms.Testsexecutable with:Test environment(s)
11.0.100-rc.1.26420.103; runtime12.0.0-alpha.1.26458.117.Microsoft Reviewers: Open in CodeFlow