Improve DB connections handling - #4291
Merged
Merged
Conversation
A replica blocked in pg_advisory_lock() holds a snapshot that another replica's CREATE INDEX CONCURRENTLY migration waits for, so both hang until Postgres kills the waiter.
Holding a session-level advisory lock on a separate connection lets Postgres release it, e.g. via idle_in_transaction_session_timeout, while the work continues on another connection. Migrations now run on the lock connection, and server init uses a session bound to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes problems with leaking DB connections pool (no
command_timeoutcould led to full client pool with 0 connections on the DB server) and other DB connections issues:DSTACK_DB_COMMAND_TIMEOUTfor PostgreSQL operations, defaulting to 300 seconds.