Treat pre-releases as final releases in feature gates - #4296
Merged
Merged
Conversation
`_parse_version` returned `None` for any pre-release or dev build, which `_check_min_version` interprets as "latest", opening every feature gate. Since we publish rc builds (e.g. `0.21.4rc1`), a shim or runner on an rc was assumed to support features it does not have. For example, a shim on `0.20.25rc1` passed the `(0, 21, 3)` gate for restart-safe RUNNING tasks, letting the server restart a shim with running jobs on it. Ignore the pre-release, dev, post-release, and local segments instead, so `0.20.1rc1` is treated as `0.20.1`. An rc is cut from the release branch, so it normally carries the features of the version it leads to. Bare run numbers of staging builds (e.g. `1234`) still resolve to "latest".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_parse_versionreturnedNonefor any pre-release or dev build, which_check_min_versioninterprets as "latest", opening every feature gate. Since we publish rc builds (e.g.0.21.4rc1), a shim or runner on an rc was assumed to support features it does not have. For example, a shim on0.20.25rc1passed the(0, 21, 3)gate for restart-safe RUNNING tasks, letting the server restart a shim with running jobs on it.Ignore the pre-release, dev, post-release, and local segments instead, so
0.20.1rc1is treated as0.20.1. An rc is cut from the release branch, so it normally carries the features of the version it leads to. Bare run numbers of staging builds (e.g.1234) still resolve to "latest".