Conversation
When several server replicas of different versions run at the same
time, as during a rolling deployment, each of them tried to install
the component version matching its own, fighting over the instance
and reinstalling the binaries in a loop.
The server now installs a component only if it can prove that the
installed version is older than the expected one. Versions are
compared as PyPA versions rather than as strings, so equivalent
spellings such as `0.20.1` and `0.20.1.0` no longer trigger a
reinstall. An unparseable version never leads to an install: on the
installed side it means a dev build, which is assumed to be the newest
one; on the expected side it's a server misconfiguration, which is
logged as a warning.
Downgrading is still possible via `DSTACK_RUNNER_ALLOW_DOWNGRADE` and
`DSTACK_SHIM_ALLOW_DOWNGRADE`. They are meant for a server downgrade,
which requires manual actions anyway, and are incompatible with
rolling deployment.
Also:
* Drop the `DSTACK_SHIM_VERSION` fallback to `DSTACK_RUNNER_VERSION`,
which was never documented and warned about its removal for a long
time.
* Document `DSTACK_SHIM_VERSION` and `DSTACK_{RUNNER,SHIM}_VERSION_URL`,
and correct the `DSTACK_RUNNER_VERSION` description: it never
defaulted to `latest`, that is only the download URL placeholder
fallback when the version cannot be determined.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When several server replicas of different versions run at the same time, as during a rolling deployment, each of them tried to install the component version matching its own, fighting over the instance and reinstalling the binaries in a loop.
The server now installs a component only if it can prove that the installed version is older than the expected one. Versions are compared as PyPA versions rather than as strings, so equivalent spellings such as
0.20.1and0.20.1.0no longer trigger a reinstall. An unparseable version never leads to an install: on the installed side it means a dev build, which is assumed to be the newest one; on the expected side it's a server misconfiguration, which is logged as a warning.Downgrading is still possible via
DSTACK_RUNNER_ALLOW_DOWNGRADEandDSTACK_SHIM_ALLOW_DOWNGRADE. They are meant for a server downgrade, which requires manual actions anyway, and are incompatible with rolling deployment.Also:
DSTACK_SHIM_VERSIONfallback toDSTACK_RUNNER_VERSION, which was never documented and warned about its removal for a long time.DSTACK_SHIM_VERSIONandDSTACK_{RUNNER,SHIM}_VERSION_URL, and correct theDSTACK_RUNNER_VERSIONdescription: it never defaulted tolatest, that is only the download URL placeholder fallback when the version cannot be determined.