Skip to content

Resolve qs security advisories in the documentation dependency graph - #122

Merged
rmcdaniel merged 1 commit into
mainfrom
fix/qs-security-update
Sep 5, 2026
Merged

Resolve qs security advisories in the documentation dependency graph#122
rmcdaniel merged 1 commit into
mainfrom
fix/qs-security-update

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Sep 5, 2026

Copy link
Copy Markdown
Member

Summary

Select qs 6.16.0 through the existing npm override mechanism and update only its lockfile entry. Express and body-parser constrain their transitive dependency to ~6.15.1, so a lockfile-only update cannot select the patched minor release.

Addresses GHSA-4mjr-xmp4-gh2g and GHSA-x5fp-wj9c-mxmx. The published site is static; this fixes the build/development dependency graph rather than claiming a production application compromise.

Validation

  • Node 24 clean install passed (lifecycle scripts disabled for the focused local dependency check; ordinary CI ran npm ci with scripts).
  • The installed patched version, hostile constructor round-trip, and ordinary query parsing passed.
  • npm audit no longer reports qs or moderate findings. It still exits 1 for the previously documented image-size advisories and their Docusaurus dependency effects (18 high dependency entries, no upstream fix reported); this is not a zero-vulnerability audit claim.
  • Reviewed the two-file dependency diff; git diff --check passes.
  • Full public CI build and link validation passed, along with the protocol catalog and boundary checks.

No documentation prose, pipeline, or new guardrail scripts are changed.

@rmcdaniel
rmcdaniel marked this pull request as ready for review September 5, 2026 09:48
@rmcdaniel
rmcdaniel merged commit f34e7ea into main Sep 5, 2026
4 checks passed
@rmcdaniel
rmcdaniel deleted the fix/qs-security-update branch September 5, 2026 09:49
@rmcdaniel

Copy link
Copy Markdown
Member Author

Merged and deployed from f34e7ea. The GitHub Pages deployment completed successfully: https://github.com/durable-workflow/durable-workflow.github.io/actions/runs/33959019724 . Dependabot alerts 132 and 133 both report fixed at 2026-09-05 09:49:33 UTC. The organization open-alert inventory is empty; the previously recorded image-size exceptions remain separate from this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants