Skip to content

Adopt published deterministic workflow clock fix - #91

Merged
rmcdaniel merged 3 commits into
mainfrom
fix/workflow-clock-dependency
Sep 12, 2026
Merged

Adopt published deterministic workflow clock fix#91
rmcdaniel merged 3 commits into
mainfrom
fix/workflow-clock-dependency

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Sep 12, 2026

Copy link
Copy Markdown
Member

Change

Adopt published Workflow 2.0.14 for embedded execution and Server 2.3.12 for service mode. Update composer.lock and the existing qualified artifact tuple together. No SDK, Waterline, framework or other dependency update.

The engine fix prevents deadline arithmetic from mutating deterministic workflow time. Upstream: durable-workflow/workflow#512 and durable-workflow/server#163; delivery tracking: durable-workflow/workflow#511.

Validation

  • Published Workflow upgrade verification passed across supported Laravel/PHP combinations: https://github.com/durable-workflow/workflow/actions/runs/34685988306 .
  • Independent installed-package clock/deadline regression passed on 2.0.14 (8 tests / 33 assertions) and reproduced five failures on 2.0.13.
  • Server release verification passed: https://github.com/durable-workflow/server/actions/runs/34686666559 . The pulled immutable image contains Workflow source 259c32b86d132bdbac683e3bbc1de44251d45c5d and passes the clock ownership probe.
  • Focused embedded and Laravel service-mode tests against MySQL passed: 8 tests / 44 assertions.
  • Final-head CI application tests, Compose workflows and PHP/Python/Rust smoke passed against the new published image. Prepared development-image validation is the remaining check.

No new performance or SLA claim is made.

@rmcdaniel
rmcdaniel marked this pull request as ready for review September 12, 2026 09:35
@rmcdaniel

Copy link
Copy Markdown
Member Author

The focused embedded and Laravel service-mode checks pass against MySQL: 8 tests, 44 assertions with the published Workflow 2.0.14 package. The first CI run stopped before application tests because I had missed the checked-in qualified artifact tuple when updating composer.lock. The tuple now agrees with the lock; normal CI is rerunning. No application or CI behavior was changed to bypass that validation.

@rmcdaniel

Copy link
Copy Markdown
Member Author

All checks now pass, including application tests, Compose workflows, PHP/Python/Rust smoke and the prepared development image. Server 2.3.12 is publishing from durable-workflow/server#163; once its exact image is verified I will align the Server entry here as well, so the sample does not retain an image with the old engine. This remains the same dependency-update PR.

@rmcdaniel
rmcdaniel merged commit b830288 into main Sep 12, 2026
11 checks passed
@rmcdaniel
rmcdaniel deleted the fix/workflow-clock-dependency branch September 12, 2026 09:57
@rmcdaniel

Copy link
Copy Markdown
Member Author

Merged at b830288 after every final-head check passed, including the Codespaces image, PHP/Python/Rust workflow execution, Compose workflows and PHP 8.4/8.5 application tests. Main publication/verification is now running to promote the prepared image for new Codespaces.

@rmcdaniel

Copy link
Copy Markdown
Member Author

Main publication is complete: both amd64 and arm64 prepared images passed credential-free published-image qualification and the main channel was published. All main checks are green. Workflow 2.0.14 and Server 2.3.12 are now the checked-in Sample App tuple. Publication run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants