Prevent poll backpressure from starving other task kinds - #67
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
September 11, 2026 15:26
Member
Author
|
Published follow-through: 2.0.10 is installable from Packagist, source 19b2695. Fresh published-consumer smoke passed: https://github.com/durable-workflow/sdk-php/actions/runs/34616341682 (Server 2.1.0). The installed-package deterministic backpressure reproduction also passed: 60 simulated seconds, 60 workflow polls, 59 activity polls, 59 query polls, 11 heartbeats, graceful shutdown. Both installed older negative controls had zero activity/query polls. The affected Server consumer update is durable-workflow/server#161; no Server runtime dependency or unchanged Python/Rust release is required. The original paid-soak timeout investigation remains separate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #66.
The PHP worker can remain in one task-kind retry loop indefinitely after a typed HTTP 429
long_poll_capacity_exhaustedrefusal, starving activities and queries despite successful heartbeats.After the existing interruptible backoff, return that validated empty-task refusal to
tick()so the other task kinds get a turn. No lease was acquired. Ambiguous connection/database/storage failures retain their existing retry identity and handling; no Server admission setting or wait deadline changes.Verification
Prepares PHP SDK 2.0.10. Publication, installed-package regression, published service-mode smoke and the Server soak consumer update remain required before issue closure. The short local Server run completed 60/60 workflows without reproducing the six paid-run timeouts; this fix is not claimed as their complete diagnosis. Server investigation: durable-workflow/server#137.