Preserve soak evidence when resource sampling fails - #160
Merged
Conversation
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the sampler crash observed in scheduled run 34597695626; related to #137.
Unavailable:output becomes a failed observation, notValueError.Validation
python3 -m unittest tests/Unit/Support/server_soak_test.py tests/Unit/Support/vultr_soak_cleanup_test.py: 27 tests pass.py_compile, diff check and repository publication check pass.The daily schedule is paused (
DW_PERF_SOAK_ENABLED=false) pending repair and review, with no extra paid run triggered. The prior run also recorded six workflow result timeouts and two readiness timeouts; this instrumentation change does not fix or waive those failures and is not an endurance/capacity pass.No public runtime/protocol/default-image behavior changes. No package release or SDK rebuild is required for this harness-only change; normal public CI owns the smoke check.