fix(backstage): bump image to 53692a6 (keycloak-auth plugin registration fix) - #14
Merged
Merged
Conversation
…ion fix) register keycloak auth via createFrontendPlugin extensions instead of the dropped createFrontendModule apis field; valueURL ?v=14 -> ?v=15
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates Backstage to the image containing the Keycloak auth plugin registration fix and refreshes ArgoCD’s values cache-buster.
Changes:
- Bumps the Backstage image tag.
- Changes the values URL from
?v=14to?v=15.
File summaries
| File | Description |
|---|---|
helm/releases/backstage/values.yaml |
Updates the Backstage image tag. |
bootstrap/appset-helm.yaml |
Refreshes the remote values URL cache-buster. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the Backstage image to 53692a629fc8a9b46bb702e4d18a7dac0e4187f4 and refresh the valueURL (?v=14 -> ?v=15).
Why
Frontend crashed with: NotImplementedError: No implementation available for apiRef{auth.keycloak}
Root cause: App.tsx registered keycloak auth via createFrontendModule({apis:[...]}), but createFrontendModule (module 25111) has NO apis field and silently drops it. In v1.53.1, ApiBlueprints are registered via the extensions array of a plugin (createFrontendPlugin), as in the upstream example (plugins/app/src/plugin.ts).
Fix (built in the image, this PR only points gitops at it)
Replace createFrontendModule({pluginId:'app', apis:[keycloakAuthApi], extensions:[keycloakSignInPage]}) with createFrontendPlugin({pluginId:'keycloak-auth', extensions:[keycloakAuthApi, keycloakSignInPage]}).
Verification done
Changes