test(sonarqube): E1 — remove 26.5.0 community branch plugin stack entirely, test stock 26.7 (?v=6) - #15
Merged
Conversation
…irely, test stock 26.7 (?v=6)
There was a problem hiding this comment.
🟡 Changes recommended
The cleanup init container can report success despite failing to remove the stale plugin.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Removes the legacy SonarQube branch-plugin stack to test stock 26.7 search behavior.
Changes:
- Adds PVC cleanup for the stale plugin JAR.
- Removes plugin installation and Java agents.
- Bumps the ArgoCD values cache-buster to
v=6.
File summaries
| File | Summary |
|---|---|
helm/releases/sonarqube/values.yaml |
Removes the plugin stack and adds PVC cleanup. Moderate issue: cleanup masks rm failures and should propagate errors. |
bootstrap/appset-helm.yaml |
Updates the values URL cache-buster to force reload. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - sh | ||
| - -c | ||
| args: | ||
| - rm -f /opt/sonarqube/extensions/plugins/sonarqube-community-branch-plugin-*.jar && echo removed-stale-branch-plugin || echo no-stale-branch-plugin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2 already proved the 26.5.0 community branch plugin boots fine on stock 26.7 (webapp override removed, plugin+agents kept) but search is STILL empty — so the plugin stack's search-path hooks are the remaining suspect. This removes the jar + both javaagents (webapp override already removed in E2). Branch/PR analysis is DISABLED while live. Because /opt/sonarqube/extensions/plugins is PVC-backed, a cleanup-branch-plugin init container rm -f's the stale 26.5.0 jar from the PVC first. Triggers StatefulSet roll (brief outage ~3-5 min). Reversible by reverting (re-adds jar + agents; ?v re-bump needed to bust the ArgoCD raw-valueFiles cache). Verification: search_projects should return 15 components.