fix(sonarqube): source JDBC password from sonarqube-postgresql (Vault) - #19
Merged
Merged
Conversation
…) to match DatabaseRole
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changed Secret exists and is the same credential source referenced by the SonarQube DatabaseRole.
Review effort: Lite
Findings: None
What changed in this PR
Aligns SonarQube’s JDBC password with the Vault-backed secret used by its CNPG DatabaseRole, preventing credential drift.
Changes:
- Uses
sonarqube-postgresqlfor JDBC credentials. - Bumps the ArgoCD values URL cache-buster.
| File | Description |
|---|---|
helm/releases/sonarqube/values.yaml |
Points JDBC password sourcing to the Vault-backed Secret. |
bootstrap/appset-helm.yaml |
Forces ArgoCD to reload updated Helm values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SonarQube read its DB password from CNPG-generated sonarqube-db-app while the app role is sourced from Vault via sonarqube-postgresql (DatabaseRole). They diverge on Vault rotation -> SQ loses DB auth. Point SQ at sonarqube-postgresql (same source as the role). Bump valueURL cache-buster.