feat(workspace-details): add Change Editor to workspace Overview tab by olexii4 · Pull Request #1663 · eclipse-che/che-dashboard

olexii4 · 2026-09-03T23:34:14Z

What does this PR do?

Adds a Change Editor form group to the Workspace Details → Overview tab, following the same UX pattern as "Change AI Tools".

When a workspace is stopped, a pencil button opens a modal with radio buttons listing all available editors (grouped by display name). Each editor group with multiple versions shows an inline version picker (EllipsisV dropdown), matching the existing EditorSelector gallery in Create Workspace. On confirm, the dashboard:

Creates a new DevWorkspaceTemplate for the selected editor (reusing DevWorkspaceClient.createDevWorkspaceTemplate, which sets ownerReferences and injects cluster env vars).
Patches the workspace — updates che.eclipse.org/che-editor, the devfile-source factory params, and spec.contributions[0].kubernetes.name in one atomic PATCH.
Deletes the old DevWorkspaceTemplate (the backend DELETE route already existed; a deleteTemplate frontend wrapper is added to devWorkspaceTemplateApi.ts).

The button is disabled when the workspace is not STOPPED or FAILED, using the same isReadonly guard already in place for Name, Storage Type, and AI Tool.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes https://redhat.atlassian.net/browse/CRW-10647

Is it tested? How?

Deploy Eclipse Che with the dashboard image from this PR.
Create a workspace (any sample, any editor).
Stop the workspace, then navigate to Workspace Details → Overview.
Verify the Editor row shows the current editor name and version with a pencil icon.
Click the pencil — the Change Editor modal opens with radio buttons for each available editor and an EllipsisV version picker for editors with multiple versions.
Select a different editor, optionally pick a non-default version, and click Save.
Verify the Overview tab updates to show the new editor.
Start the workspace — confirm it opens in the newly selected editor.

Without this PR: no way to change the editor on an existing stopped workspace without recreating it.

Release Notes

Added "Change Editor" option to the workspace Overview tab, allowing users to switch the IDE of a stopped workspace without recreating it.

Docs PR

eclipse-che/che-docs#3192

che-bot · 2026-09-03T23:34:23Z

Click here to review and test in web IDE:

github-actions · 2026-09-03T23:49:54Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

github-actions · 2026-09-04T13:50:39Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

github-actions · 2026-09-04T13:57:18Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

github-actions · 2026-09-04T14:21:41Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

Creates new DevWorkspaceTemplate, patches workspace annotations and spec.contributions, then deletes the old template. Reuses createDevWorkspaceTemplate and patchWorkspace from existing code. Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

Assisted-by: Claude Haiku 4.5 Signed-off-by: Oleksii Orel <oorel@redhat.com>

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

The DELETE /namespace/:ns/devworkspacetemplates/:name route was wrapped in isLocalRun(), making it unavailable in production deployments. The changeWorkspaceEditor action creator calls deleteTemplate() after switching the editor, so the orphaned old template was never cleaned up on a real cluster. Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

- Overview tab: remove version from editor label; hide pencil button (not just disable) when workspace is not stopped/failed; add tooltip icon (Popover + FormGroupLabelHelp) matching AI Tool row alignment - Change Editor modal: fixed header (title + filter) does not scroll with the list; filter now searches display name, all versions, and all descriptions; filter placeholder shortened to "Filter by"; filter input capped at max-width 30%; version labels shown on all rows, not just the selected one; checkbox style (type=checkbox) instead of radio; versionLabel style matches AI Tool (height, margin-left, no min-width); custom editor shown as informational item when current editor ID is unknown to the registry - After confirming an editor change, show "Workspace has been updated" success alert or a danger alert with the error message, matching the AI Tool behaviour (uses AppAlerts via lazyInject) Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

- devWorkspaceTemplateApi: add deleteTemplate success + error tests - changeWorkspaceEditor: add error-path and same-name-skip tests - editor helpers: add displayName/name fallback tests - SelectorModal: add filter-reset-on-close test - EditorFormGroup: add architecture-filter test Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

github-actions · 2026-09-04T15:24:01Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

github-actions · 2026-09-04T15:28:56Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

olexii4 · 2026-09-06T02:47:42Z

/retest

- Use findIndex to locate the editor contribution by name instead of hard-coding index 0; fixes incorrect patch when other contributions (e.g. AI tool) precede the editor entry - Wrap old-template deletion in its own try/catch so a stale-resource error does not surface as a failed editor change after the workspace is already patched - Guard devfile-source regex replacement — only run it when the annotation actually contains che-editor=, leaving unrelated sources unchanged - Replace Checkbox with Radio in EditorSelectorModal so screen readers correctly announce single-selection semantics Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

github-actions · 2026-09-07T13:09:09Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

olexii4 · 2026-09-07T16:52:35Z

/retest

codecov · 2026-09-07T18:22:50Z

Codecov Report

❌ Patch coverage is 95.59659% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.47%. Comparing base (e9aa836) to head (c96a05d).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
.../dashboard-frontend/src/services/helpers/editor.ts	83.75%	13 Missing ⚠️
...es/actions/actionCreators/changeWorkspaceEditor.ts	93.67%	9 Missing and 1 partial ⚠️
...kspaceDetails/OverviewTab/Editor/SelectorModal.tsx	98.00%	6 Missing ⚠️
...ages/WorkspaceDetails/OverviewTab/Editor/index.tsx	98.50%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1663      +/-   ##
==========================================
+ Coverage   92.45%   92.47%   +0.02%     
==========================================
  Files         609      612       +3     
  Lines       63850    64556     +706     
  Branches     5011     5107      +96     
==========================================
+ Hits        59031    59698     +667     
- Misses       4754     4791      +37     
- Partials       65       67       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

batleforc · 2026-09-07T19:46:46Z

@olexii4 I did just deploy it and had some problems:

i was on vscode latest but when i chose another ide it set the vscode to insider

And that's the bug I had for the past 20 min of test (except for chemuxer that refuse to boot but that's another subject)

When switching editor groups the modal always reset the version to group.versions[0].version. If the first version in the list did not match the current editor's version (e.g. insiders before latest), going back to the original editor showed the wrong version. Replace selectedVersion: string with versionsByGroup: Record<string, string> so each group independently tracks its selected version for the duration of the modal session. State is reset on modal open so a previous session's choices never persist across Cancel/reopen. Adds three regression tests covering the reported scenario. Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

github-actions · 2026-09-07T22:22:25Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

olexii4 · 2026-09-08T08:27:44Z

@batleforc thanks for catching this.

Fixed in efa10707: replaced the single selectedVersion field with a versionsByGroup map (Record<string, string>) so each editor group independently remembers its version within the modal session.

Could you test it after the changes?

batleforc · 2026-09-08T17:46:46Z

@olexii4 Looks good to me. The IDE Switch works perfectly for me.

svor

lgtm

Screen.Recording.2026-09-09.at.17.28.01.mov

ibuziuk

Great job 👍

openshift-ci · 2026-09-10T07:37:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4, svor

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dmytro-ndp · 2026-09-11T17:31:58Z

@olexii4: hello,
thanks for the great UX improvement!

I have a suggesting about how to slightly improve selection of editor in the Change Editor dialog.

IMHO it's not so convenient to locate editor by scrolling the page:

It would be more convenient for usage if we could get rid of vertical scroll bar, which should be possible to do by increasing the dialog window height and removal the second line with editor description from the list, like JetBrains CLion for Eclipse Che - latest, and decrease line margins:

Also, the latest and next labels to the right of the editor name color scheme looks a little bit odd in the Dark theme, IMHO.

Another possible improvement is displaying the list of editors in the same order as on the Editor Selector section in Create Workspace page:

It would be appreciated if you could take a look.

Move editor description from inline text to hover tooltip, sort editors the same way as the Create Workspace editor gallery (che-code first, versions by priority, deprecated last), and adopt the shared TagLabel component for version/tag badges. Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

openshift-ci · 2026-09-15T13:57:28Z

New changes are detected. LGTM label has been removed.

github-actions · 2026-09-15T14:08:37Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

Remove dotted underline from editor names, collapse margins between editor list items, and increase list max-height from 18rem to 20rem. Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2026-09-15T14:45:34Z

@olexii4: hello, thanks for the great UX improvement!

I have a suggesting about how to slightly improve selection of editor in the Change Editor dialog.
...

@dmytro-ndp I have fixed:

The PatternFly Content h6 elements added large block margins that could not be overridden by a CSS module selector. Removing the wrapper eliminates the spacing issue. Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

github-actions · 2026-09-15T14:59:14Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

github-actions · 2026-09-15T15:08:16Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

svor · 2026-09-16T08:21:06Z

/retest

dmytro-ndp · 2026-09-16T17:41:11Z

@olexii4 : thank you for handling PR review feedback.

While the Change Editor dialog looks more concise after your changes, there is still room for improvement: rewrite or get rid of editor line hints with the Editor description, which overlap the lines above significantly::

I have also successfully tested switching between the web IDE and VS Code SSH IDEs, as mentioned as a common case in the fixed issue https://redhat.atlassian.net/browse/CRW-10647.

At the same time, there was an issue where if you leave the Visual Studio Code (desktop) (SSH) landing page after workspace startup, the User Dashboard redirects to this opened page regardless of whether the workspace editor was changed to VS Code Editor later:
Screencast From 2026-09-16 20-32-32.webm

Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

github-actions · 2026-09-21T13:58:33Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1663 (linux/amd64, linux/arm64, linux/s390x)

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1663", name: che-dashboard}]}}]"

olexii4 · 2026-09-21T14:08:26Z

@dmytro-ndp I have fixed it. Could you recheck it?

olexii4 requested review from akurinnoy and ibuziuk as code owners September 3, 2026 23:34

olexii4 added 10 commits September 4, 2026 18:10

feat(editor): add grouping and annotation helpers

a82a3a4

Assisted-by: Claude Haiku 4.5 Signed-off-by: Oleksii Orel <oorel@redhat.com>

feat(workspace-details): add EditorSelectorModal

7f4bc01

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

feat(workspace-details): add EditorFormGroup to Overview tab

e7bf22c

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

feat(workspace-details): wire EditorFormGroup into Overview tab

19cb3b5

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

fix(workspace-details): rename filter aria-label to "Filter editors by"

133683f

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

fix(workspace-details): adjust Overview tab readonly/editable alignment

b0a131f

Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the che-23935 branch from 3cebf99 to 2b372ae Compare September 4, 2026 15:14

olexii4 mentioned this pull request Sep 4, 2026

[Dashboard] Ide Switch eclipse-che/che#23935

Open

olexii4 requested a review from svor September 7, 2026 14:09

eclipse-che deleted a comment from codecov Bot Sep 7, 2026

olexii4 mentioned this pull request Sep 9, 2026

docs: add Change Editor on a workspace procedure eclipse-che/che-docs#3192

Open

svor approved these changes Sep 9, 2026

View reviewed changes

openshift-ci Bot assigned svor Sep 9, 2026

openshift-ci Bot added the lgtm label Sep 9, 2026

ibuziuk approved these changes Sep 10, 2026

View reviewed changes

openshift-ci Bot assigned ibuziuk Sep 10, 2026

svor requested a review from dmytro-ndp September 10, 2026 11:21

openshift-ci Bot removed the lgtm label Sep 15, 2026

fix(workspace-details): reduce editor list spacing and drop underline

08d5b90

Remove dotted underline from editor names, collapse margins between editor list items, and increase list max-height from 18rem to 20rem. Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 marked this pull request as draft September 16, 2026 13:01

openshift-ci Bot added the do-not-merge/work-in-progress label Sep 16, 2026

olexii4 marked this pull request as ready for review September 16, 2026 13:01

openshift-ci Bot removed the do-not-merge/work-in-progress label Sep 16, 2026

fix(workspace-details): clear stale IDE redirect on editor change

b08dc54

Assisted-by: Claude Opus 4.6 Signed-off-by: Oleksii Orel <oorel@redhat.com>

Conversation

olexii4 commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

Uh oh!

che-bot commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

olexii4 commented Sep 6, 2026

Uh oh!

github-actions Bot commented Sep 7, 2026

Uh oh!

olexii4 commented Sep 7, 2026

Uh oh!

codecov Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

batleforc commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 7, 2026

Uh oh!

olexii4 commented Sep 8, 2026

Uh oh!

batleforc commented Sep 8, 2026

Uh oh!

svor left a comment

Choose a reason for hiding this comment

Uh oh!

ibuziuk left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Sep 10, 2026

Uh oh!

dmytro-ndp commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Sep 15, 2026

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

olexii4 commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

svor commented Sep 16, 2026

Uh oh!

dmytro-ndp commented Sep 16, 2026

Uh oh!

github-actions Bot commented Sep 21, 2026

Uh oh!

olexii4 commented Sep 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

olexii4 commented Sep 3, 2026 •

edited

Loading

codecov Bot commented Sep 7, 2026 •

edited

Loading

batleforc commented Sep 7, 2026 •

edited

Loading

dmytro-ndp commented Sep 11, 2026 •

edited

Loading

olexii4 commented Sep 15, 2026 •

edited

Loading