Remove the unused PngDeflater - #3488
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
vogella
force-pushed
the
swt-perf-improvements
branch
from
August 6, 2026 14:23
daf16a7 to
7ef748b
Compare
PngEncoder has compressed image data with java.util.zip.DeflaterOutputStream for a long time, which left PngDeflater without a single caller anywhere in the repository. The class was a partial Java port of PuTTY's sshzlib.c, so the PuTTY licence section in the three about.html files covered code that is no longer shipped. That section goes away with it.
vogella
force-pushed
the
swt-perf-improvements
branch
from
August 6, 2026 14:29
7ef748b to
9130c44
Compare
vogella
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PngEncoderhas compressed image data withjava.util.zip.DeflaterOutputStreamfor a long time, which leftPngDeflaterwithout a single caller anywhere in the repository. It is 621 lines of hand-written deflate implementation that nothing reaches.The class was a partial Java port of PuTTY's sshzlib.c, so the PuTTY licence section in the three about.html files described code that would no longer be shipped. That section is removed along with it. Please give the legal file changes a careful look; the removed block is byte-identical in all three files and covered nothing else.
After the change no reference to
PngDeflateror PuTTY remains anywhere in the tree.Note: the branch is still named
swt-perf-improvementsbecause it originally carried image codec optimizations too. Those have been dropped from this PR and will come separately.