Remove the unused IPropertyBag - #3490
Open
vogella wants to merge 1 commit into
Open
Conversation
IPropertyBag was added in 2010 together with the WebKit browser backend for Windows (bug 220098) and WebUIDelegate was its only caller. That backend was deleted in 2020 by bug 560190, but the COM wrapper was left behind and has had no caller since. The GUID named IIDIPropertyBag in Accessible is a local variable in a diagnostic interface-id to name mapping and is unrelated to this class.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This COM wrapper arrived in 2010 with the WebKit browser backend for Windows (bug 220098), where
WebUIDelegatewas its only caller. That backend was deleted in 2020 by bug 560190, butIPropertyBagwas left behind and nothing has referenced it since.The only other match for the name in the tree is the
IIDIPropertyBagGUID inAccessible, a local variable in the diagnostic interface-id to name mapping. It is unrelated to this class and stays.Verified by compiling the win32 bundle from source with both javac and ecj after the removal.