[Win32] Add missing null check in Table tooltip positioning #3487 - #3491
Open
HeikoKlare wants to merge 1 commit into
Open
[Win32] Add missing null check in Table tooltip positioning #3487#3491HeikoKlare wants to merge 1 commit into
HeikoKlare wants to merge 1 commit into
Conversation
…latform#3487 Table and tree implementations contain a tooltip repositioning functionality to make a tooltip fit into a single monitor. The reason is that tooltips spanning multiple monitors of different zoom can freeze the UI thread on Windows. While in the Tree implementation the repositioning was properly guarded with a null check for the adjusted position, this check is missing in the Table implementation can lead to a NullPointerException in case the calculated result is actually null. This change fixes that by adding an according null check, which effectively skips the tooltip repositioning in case the correct monitor to fit into could not be found. Fixes eclipse-platform#3487
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table and tree implementations contain a tooltip repositioning functionality to make a tooltip fit into a single monitor. The reason is that tooltips spanning multiple monitors of different zoom can freeze the UI thread on Windows.
While in the Tree implementation the repositioning was properly guarded with a null check for the adjusted position, this check is missing in the Table implementation can lead to a NullPointerException in case the calculated result is actually null. This change fixes that by adding an according null check, which effectively skips the tooltip repositioning in case the correct monitor to fit into could not be found.
Fixes #3487
Originally introduced with: #2241