Wait for the deferred zoom font disposal in ConsoleTests - #2861
Merged
iloveeclipse merged 1 commit intoAug 10, 2026
Merged
Conversation
ConsoleZoomHandler disposes the custom zoom fonts of a removed console one UI cycle later via timerExec, but the test asserted the disposal immediately after the console list had drained. On a fast machine the assertion could therefore run before the timer fired, which made testRemovingConsoleDisposesZoomFont fail sporadically on the macOS CI runners. Poll for both conditions with TestUtil.waitWhile instead.
Contributor
iloveeclipse
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConsoleZoomHandlerdisposes the custom zoom fonts of a removed console one UI cycle later viatimerExec, buttestRemovingConsoleDisposesZoomFontasserted the disposal immediately after the console list had drained. When the console list emptied quickly and nothing pumped the display afterwards, the assertion ran before the timer fired, so the test failed sporadically on the macOS CI runners.The test now polls for both conditions with
TestUtil.waitWhileinstead of a single immediate assertion, which also replaces the hand-rolled wait loop. Locally all 16ConsoleTestspass.