refactor: simplify / ungeneralize needs.json export of project_url - #797
Closed
AlexanderLanin wants to merge 1 commit into
Closed
refactor: simplify / ungeneralize needs.json export of project_url#797AlexanderLanin wants to merge 1 commit into
AlexanderLanin wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Configuration snapshots and stacked exporter wrappers can produce stale or incorrect project URLs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Refactors Needs JSON export registration around the SCORE-specific project_url field.
Changes:
- Adds explicit project URL export and override support.
- Adds regression tests for configuration and overrides.
File summaries
| File | Description |
|---|---|
external_needs.py |
Implements project URL export registration. |
test_external_needs.py |
Tests missing, configured, and overridden values. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Documentation preview for this pull request is available at: |
AlexanderLanin
force-pushed
the
pr/needs-exporter-api
branch
5 times, most recently
from
September 3, 2026 07:26
9171c09 to
8c48f40
Compare
AlexanderLanin
force-pushed
the
pr/needs-exporter-api
branch
from
September 3, 2026 07:31
8c48f40 to
470820d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
The Needs JSON exporter currently exposes a generic helper whose field list, validation policy, and output values are passed separately. That makes a one-field customization harder to understand and makes it awkward for specialized exports that must write different metadata. It's simply super difficult to extend a generic exporter. And we only export one value.
What changed
project_urlis validated and exported from Sphinx configuration.