Exposing the //config:test_image to overload different images to test on - #525
Draft
MaciejKaszynski wants to merge 2 commits into
Draft
Exposing the //config:test_image to overload different images to test on#525MaciejKaszynski wants to merge 2 commits into
MaciejKaszynski wants to merge 2 commits into
Conversation
MaciejKaszynski
requested review from
FScholPer,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 25, 2026 12:46
MaciejKaszynski
requested a deployment
to
workflow-approval
August 25, 2026 12:46 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 25, 2026 12:46 — with
GitHub Actions
Waiting
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
danth
suggested changes
Aug 25, 2026
| "--test_runner", | ||
| action="store", | ||
| default=None, | ||
| help="Program to run the test with e.g. valgrind.", |
Member
There was a problem hiding this comment.
Suggested change
| help="Program to run the test with e.g. valgrind.", | |
| help="Wrapper program to run the test inside, for example a debugger. The wrapper program will be called with the test binary as its first argument, followed by any number of test arguments. It must execute the test binary with the provided arguments and exit when complete.", |
MaciejKaszynski
requested a deployment
to
workflow-approval
August 26, 2026 10:36 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 26, 2026 10:36 — with
GitHub Actions
Waiting
Co-authored-by: Daniel Thwaites <danth@danth.me> Signed-off-by: Maciej Kaszynski <161459353+MaciejKaszynski@users.noreply.github.com>
MaciejKaszynski
force-pushed
the
expose-image-label
branch
from
August 26, 2026 10:37
00115ca to
5bdabf3
Compare
MaciejKaszynski
requested a deployment
to
workflow-approval
August 26, 2026 10:37 — with
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
August 26, 2026 10:37 — with
GitHub Actions
Waiting
Merged
| "--test_runner", | ||
| action="store", | ||
| default=None, | ||
| help="Program to run the test with e.g. valgrind.", |
Contributor
There was a problem hiding this comment.
Would be great if there is an example in one of the readme files how this is used, e.g. for valigrind
MaciejKaszynski
marked this pull request as draft
August 31, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.