Alive monitor refactor cleanup - #571
Open
WilliamRoebuck wants to merge 15 commits into
Open
Conversation
WilliamRoebuck
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 31, 2026 10:48
WilliamRoebuck
requested a deployment
to
workflow-approval
August 31, 2026 10:48 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 31, 2026 10:48 — with
GitHub Actions
Waiting
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
WilliamRoebuck
force-pushed
the
feature/alive-mon-refactor-cleanup
branch
from
August 31, 2026 12:13
082e24e to
eed747a
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 31, 2026 12:13 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 31, 2026 12:13 — with
GitHub Actions
Waiting
…into feature/process-makes-supervision
WilliamRoebuck
force-pushed
the
feature/alive-mon-refactor-cleanup
branch
from
August 31, 2026 12:18
eed747a to
9d9cbe8
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 31, 2026 12:19 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 31, 2026 12:19 — with
GitHub Actions
Waiting
| explicit SupervisionHandle(IdentifierHash process_id, std::shared_ptr<SupervisionBufferType> buffer) | ||
| : process_id_(process_id), buffer_(buffer) | ||
| { | ||
| ipc_path_ = std::move(internal::aliveInterfacePath(process_id_)); |
Contributor
There was a problem hiding this comment.
can be in the member initializer lists above
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup after #522. The last 2 commits are the new changes.