Fix incorrect behaviour on early termination

[WilliamRoebuck]

• Fixes Fix try terminate for a process that terminates quickly #553
• Fixes Fix try report completion for a self termination process that terminates quickly and is ready on termination #554
• Fixes Fix flaky sandbox_options test #503
• Also includes some renames in SafeProcessMap to make it a bit easier to understand
• Added "reason" to UnexpectedTermination event instead of assuming kErrorAfterReady
• Extract isValidTermination() and isReporting() common functions for ProcessInfoNode

Most likely does not \fix\ #567 but I have not been able to reproduce that failure.

Fix details

The case where the process terminated during activation was not handled correctly. The main fix is at the end of startProcess(), where we now handle the stored result of the last termination instead of ignoring when a termination happened and hoping that tryHandleTermination() happened at just the right time to report an unexpected termination.

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: 2ca1f857-eaf2-4a4a-88b7-de585806433b
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (48 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (131 packages loaded, 404 targets configured)

Analyzing: target //:license-check (155 packages loaded, 3285 targets configured)

Analyzing: target //:license-check (157 packages loaded, 8986 targets configured)

Analyzing: target //:license-check (163 packages loaded, 9368 targets configured)

Analyzing: target //:license-check (168 packages loaded, 9417 targets configured)

Analyzing: target //:license-check (169 packages loaded, 9541 targets configured)

INFO: Analyzed target //:license-check (173 packages loaded, 11555 targets configured).
[15 / 16] [Prepa] Generating Dash formatted dependency file ...
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 23.529s, Critical Path: 0.38s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[MaciejKaszynski]

I don't think we should have this as a member as it's a copy the data in the config, should just add
auto& is_reporting = to the methods that use it.

[WilliamRoebuck]

Hmm, I don't think it can be considered a copy because the config doesn't directly provide whether the component is reporting or not. At the moment is_reporting = !config::Native, but that might not always be the case. I prefer the function because otherwise we repeat logic in several places, even if the logic is just !=

[MaciejKaszynski]

This is only used in tryHandleTermination should this just be a lambda?

[WilliamRoebuck]

Removed in 3158c76, no lambda needed