Skip to content

fix: correct spacing in KVS log messages - #403

Open
atarekra wants to merge 1 commit into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:kvs-log-message-spacing
Open

fix: correct spacing in KVS log messages#403
atarekra wants to merge 1 commit into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:kvs-log-message-spacing

Conversation

@atarekra

Copy link
Copy Markdown
Contributor

Closes #402

The score logger already puts a space between streamed items, but the literals in
kvs.cpp add their own on top, so messages come out like this:

error: file  ./data/kvs_1_0.json  could not be read
Failed to open file ' ./data/kvs_1_0.hash '

Took the extra spaces back out. A few lines had quotes or brackets sitting right
against a value, which can't be kept since the separator always lands inside
them, so those are replaced. No logic or log level changes.

The score logger puts a space between each streamed item, but the string
literals in kvs.cpp carry their own spaces too, so messages came out
double spaced. Where a value was wrapped in quotes the spaces ended up
inside them:

  error: file  ./data/kvs_1_0.json  could not be read
  Failed to open file ' ./data/kvs_1_0.hash '

Removed the extra spaces from the literals. A few lines had quotes or
brackets sitting flush against a value, which can't be kept since the
separator always goes in between, so those are replaced. No logic or log
level changes.

Signed-off-by: atarekra <ahmed.tarek-ramadan@valeo.com>
@github-actions

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: e6072beb-fe57-44fe-aeb8-76c425f89027
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (149 packages loaded, 1811 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (160 packages loaded, 9304 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9321 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11510 targets configured).
[1 / 1] no actions running
[14 / 17] Generating Dash formatted dependency file ...; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.590s, Critical Path: 1.90s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log messages in kvs.cpp have doubled spaces

1 participant