fix: correct spacing in KVS log messages - #403
Open
atarekra wants to merge 1 commit into
Open
Conversation
The score logger puts a space between each streamed item, but the string literals in kvs.cpp carry their own spaces too, so messages came out double spaced. Where a value was wrapped in quotes the spaces ended up inside them: error: file ./data/kvs_1_0.json could not be read Failed to open file ' ./data/kvs_1_0.hash ' Removed the extra spaces from the literals. A few lines had quotes or brackets sitting flush against a value, which can't be kept since the separator always goes in between, so those are replaced. No logic or log level changes. Signed-off-by: atarekra <ahmed.tarek-ramadan@valeo.com>
atarekra
requested review from
PandaeDo,
antonkri,
umaucher and
vinodreddy-g
as code owners
August 31, 2026 11:12
atarekra
requested a deployment
to
workflow-approval
August 31, 2026 11:12 — with
GitHub Actions
Waiting
atarekra
requested a deployment
to
workflow-approval
August 31, 2026 11:12 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #402
The score logger already puts a space between streamed items, but the literals in
kvs.cpp add their own on top, so messages come out like this:
Took the extra spaces back out. A few lines had quotes or brackets sitting right
against a value, which can't be kept since the separator always lands inside
them, so those are replaced. No logic or log level changes.