Skip to content

fix: baselibs testlinks #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PiotrKorkus wants to merge 1 commit into from
Closed

fix: baselibs testlinks #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bazel_common/score_modules_target_sw.MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ git_override(
patch_strip = 1,
patches = [
"//patches/baselibs:001-restore-trace-library-mock-visibility.patch",
"//patches/baselibs:002-flatbuffers-allocator-test-drop-raw-symbol-links.patch",
],
remote = "https://github.com/eclipse-score/baselibs.git",
)
Expand Down
3 changes: 2 additions & 1 deletion known_good.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"repo": "https://github.com/eclipse-score/baselibs.git",
"hash": "06f6b9b7d48710438ea4664d84da5143594763cb",
"bazel_patches": [
"//patches/baselibs:001-restore-trace-library-mock-visibility.patch"
"//patches/baselibs:001-restore-trace-library-mock-visibility.patch",
"//patches/baselibs:002-flatbuffers-allocator-test-drop-raw-symbol-links.patch"
],
"metadata": {
"extra_test_config": [
Expand Down
94 changes: 94 additions & 0 deletions patches/baselibs/002-flatbuffers-allocator-test-drop-raw-symbol-links.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
diff --git a/score/flatbuffers/details/flatfbuffer_allocator_test.cpp b/score/flatbuffers/details/flatfbuffer_allocator_test.cpp
index f99188c..32d4a26 100644
--- a/score/flatbuffers/details/flatfbuffer_allocator_test.cpp
+++ b/score/flatbuffers/details/flatfbuffer_allocator_test.cpp
@@ -74,7 +74,6 @@ class SimpleAllocator : public ::flatbuffers::Allocator

TEST(AllocatorTest, AllocateReturnsNonNull)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::allocate, ::flatbuffers::Allocator::deallocate");
RecordProperty("Description", "allocate returns a non-null pointer; deallocate does not crash");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "equivalence-classes");
@@ -90,7 +89,6 @@ TEST(AllocatorTest, AllocateReturnsNonNull)

TEST(AllocatorTest, AllocateSingleByte)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::allocate, ::flatbuffers::Allocator::deallocate");
RecordProperty("Description", "allocate and deallocate a single byte");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "boundary-value-analysis");
@@ -105,7 +103,6 @@ TEST(AllocatorTest, AllocateSingleByte)

TEST(AllocatorTest, AllocateLargeRegion)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::allocate, ::flatbuffers::Allocator::deallocate");
RecordProperty("Description", "allocate and deallocate a large (1 MiB) region");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "boundary-value-analysis");
@@ -122,9 +119,6 @@ TEST(AllocatorTest, AllocateLargeRegion)

TEST(AllocatorTest, UsableThroughBasePointer)
{
- RecordProperty("FullyVerifies",
- "::flatbuffers::Allocator::allocate, ::flatbuffers::Allocator::deallocate, "
- "::flatbuffers::Allocator::~Allocator");
RecordProperty("Description", "allocator is usable through a base-class pointer; virtual destructor is exercised");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "equivalence-classes");
@@ -155,7 +149,6 @@ class AllocatorGrowsBufferTest : public ::testing::TestWithParam<GrowsBufferPara

TEST_P(AllocatorGrowsBufferTest, GrowsBuffer)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::reallocate_downward");
RecordProperty("Description", "reallocate_downward grows the buffer and returns a non-null pointer");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "equivalence-classes");
@@ -193,7 +186,6 @@ class AllocatorPreservesBackDataTest : public ::testing::TestWithParam<BackDataP

TEST_P(AllocatorPreservesBackDataTest, PreservesBackData)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::reallocate_downward");
RecordProperty("Description", "reallocate_downward copies in_use_back bytes to the tail of the new buffer");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "equivalence-classes");
@@ -239,7 +231,6 @@ class AllocatorPreservesFrontDataTest : public ::testing::TestWithParam<FrontDat

TEST_P(AllocatorPreservesFrontDataTest, PreservesFrontData)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::reallocate_downward");
RecordProperty("Description", "reallocate_downward copies in_use_front bytes to the head of the new buffer");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "equivalence-classes");
@@ -286,7 +277,6 @@ class AllocatorPreservesBothDataTest : public ::testing::TestWithParam<BothDataP

TEST_P(AllocatorPreservesBothDataTest, PreservesBothFrontAndBackData)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::reallocate_downward");
RecordProperty("Description", "reallocate_downward preserves both front and back in-use regions simultaneously");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "boundary-value-analysis");
@@ -330,7 +320,6 @@ INSTANTIATE_TEST_SUITE_P(SizeRanges,

TEST(AllocatorReallocateDownwardTest, PreserveFrontAndBackIfAllocatingNewSizeFails)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::reallocate_downward");
RecordProperty("Description", "reallocate_downward preserves front and back if new size cannot be allocated");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "boundary-value-analysis");
@@ -378,7 +367,6 @@ TEST(AllocatorReallocateDownwardTest, PreserveFrontAndBackIfAllocatingNewSizeFai

TEST(AllocatorReallocateDownwardTest, AssertsWhenNewSizeEqualsOldSize)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::reallocate_downward");
RecordProperty("Description", "reallocate_downward asserts when new_size equals old_size");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "boundary-value-analysis");
@@ -395,7 +383,6 @@ TEST(AllocatorReallocateDownwardTest, AssertsWhenNewSizeEqualsOldSize)

TEST(AllocatorReallocateDownwardTest, AssertsWhenNewSizeSmallerThanOldSize)
{
- RecordProperty("FullyVerifies", "::flatbuffers::Allocator::reallocate_downward");
RecordProperty("Description", "reallocate_downward asserts when new_size is smaller than old_size");
RecordProperty("TestType", "interface-test");
RecordProperty("DerivationTechnique", "boundary-value-analysis");
Loading