feat: Quality pack targets - #150
GabrielPinheiro7891 wants to merge 30 commits into
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
This doesn't match up with the score process module_template.
I've started the component requirements work for the other components following the guidelines, see #151 and #149. I think we should have this structure across all the components. The actual build of the docs themselves won't work until the update to docs-as-code 6.0 is merged in #148 (updating to use docs_bundles so that we can have docs alongside source).
Please update to match the template.
There was a problem hiding this comment.
I pushed the commit Update to match module_template , to match the template. However, like you said, until docs-as-code 6.0 isn't merged this will not work as we get:
"broken_references": [
{
"testcase": "testcase__SystemClockTest__NowReturnsTimepointSuitableForDurationArithmetic_nckqh",
"missing_need": "comp_req__system_time__snapshot"
},
{
"testcase": "testcase__SteadyClockTest__NowReturnsTimepointSuitableForDurationArithmetic_dhwjw",
"missing_need": "comp_req__steady_time__snapshot"
},
{
"testcase": "testcase__HighResSteadyClockTest__NowReturnsTimepointSuitableForDurationArithmetic_ogazc",
"missing_need": "comp_req__high_res_steady_time__snapshot"
},
{
"testcase": "testcase__VehicleClockTest__NowReturnsSynchronizedStatusAndTimepoint_xggob",
"missing_need": "comp_req__vehicle_time__snapshot"
},
{
"testcase": "testcase__VehicleClockTest__InitForwardsToBackend_vsaqs",
"missing_need": "comp_req__vehicle_time__lifecycle"
}
]
160bc42 to
7444a7c
Compare
…ality-pack-targets
…ality-pack-targets
…ality-pack-targets
…ality-pack-targets
…ality-pack-targets
| :id: doc__time_requirements | ||
| :status: valid | ||
| :version: 1 | ||
| :safety: QM |
There was a problem hiding this comment.
Everything should be set to ASIL_B as the whole time library is ASIL now
| srcs = ["high_res_steady_clock_adapter_test.cpp"], | ||
| features = COMPILER_WARNING_FEATURES, | ||
| tags = [ | ||
| "component", |
There was a problem hiding this comment.
I don't think, that we should mark these as component tests because they do unit testing only.
Also, wondering if this combination of tags (component + unit) is possible.
But as shortly discussed on the call let's recheck documentation how this should be handled ...
|
|
||
| TEST(HighResSteadyClockTest, NowReturnsTimepointSuitableForDurationArithmetic) | ||
| { | ||
| ::testing::Test::RecordProperty("FullyVerifies", "comp_req__high_res_steady_time__snapshot"); |
There was a problem hiding this comment.
I don't think these tests (in general) do full verification of the requirement.
As mentioned in prev comment - we need to check docs ...
Co-authored-by: Björn Hornburg <Bjoern.Hornburg@de.bosch.com> Signed-off-by: Gabriel Pinheiro <gabriel.pinheiro@etas.com>
Provide Bazel targets: unit tests, component tests, code coverage.
Added documentation