Update the Feature design by lavrovvalera · Pull Request #188 · eclipse-score/time

lavrovvalera · 2026-08-25T09:25:47Z

Summary

Adds the Time Feature Architecture to the module repository and restructures
the existing documentation to conform to the S-CORE module folder rules.

Create the feature architecture design document
Fix root docs/index.rst title and overview

The platfrom part is adapted here: eclipse-score/score#3200

Part of #85

github-actions · 2026-08-25T09:26:50Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 068a8394-a336-4882-99e7-fd44657e68a1
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (79 packages loaded, 10 targets configured)

Analyzing: target //:license-check (91 packages loaded, 10 targets configured)

Analyzing: target //:license-check (110 packages loaded, 608 targets configured)

Analyzing: target //:license-check (160 packages loaded, 3174 targets configured)

Analyzing: target //:license-check (161 packages loaded, 4683 targets configured)

Analyzing: target //:license-check (167 packages loaded, 9368 targets configured)

Analyzing: target //:license-check (167 packages loaded, 9368 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9415 targets configured)

Analyzing: target //:license-check (172 packages loaded, 9417 targets configured)

Analyzing: target //:license-check (175 packages loaded, 11305 targets configured)

Analyzing: target //:license-check (176 packages loaded, 11429 targets configured)

Analyzing: target //:license-check (177 packages loaded, 11549 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11555 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 33.768s, Critical Path: 2.41s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

- Add Time Feature Architecture to docs/features/architecture/ - Add docs/conf.py with required_in_id for path validation

BjoernAtBosch

Sorry, two more

BjoernAtBosch

LGTM

ryan-steel · 2026-09-02T09:49:24Z

+   :safety: ASIL_B
+   :status: valid
+   :version: 1
+   :fulfils: feat_req__time__abs_base_api[version==1], feat_req__time__abs_sync[version==1]


From feature reqs, missing these, are they not yet implemented or should they be added here?

feat_req__time__abs_acc_qual

feat_req__time__abs_sec_qual

feat_req__time__abs_sync_log

ryan-steel · 2026-09-02T09:55:18Z

+   :status: valid
+   :version: 1
+   :includes: logic_arc_int__time__vehicle_clock, logic_arc_int__time__local_clock, logic_arc_int__time__absolute_clock
+   :fulfils: feat_req__time__mocking_apis[version==1], feat_req__time__vehicle_time_sync[version==1], feat_req__time__abs_sync[version==1]


Looks like this contains all components, so should fulfil all feature requirements:

feat_req__time__vehicle_time_sync_prec

feat_req__time__vehicle_time_time_api

feat_req__time__vehicle_time_acc_qual_api

feat_req__time__vehicle_time_time_pt_qual

feat_req__time__vehicle_time_ctrl_flow

feat_req__time__vehicle_time_sync_log

feat_req__time__abs_base_api

feat_req__time__abs_acc_qual

feat_req__time__abs_sec_qual

feat_req__time__abs_sync_log

feat_req__time__high_prec_clock_api

feat_req__time__monotonic_clock_api

basically, not, becuase this static view doesn't implement all reuqirements.
in descirbed the API ones.
that was an intention not to mention it here

ryan-steel · 2026-09-02T09:55:24Z

+   :safety: ASIL_B
+   :status: valid
+   :version: 1
+   :fulfils: feat_req__time__vehicle_time_ctrl_flow[version==1]


From feature reqs, missing these, should they be added here?

feat_req__time__vehicle_time_sync

feat_req__time__vehicle_time_sync_prec

feat_req__time__vehicle_time_time_api

feat_req__time__vehicle_time_acc_qual_api

feat_req__time__vehicle_time_time_pt_qual

feat_req__time__vehicle_time_ctrl_flow

Intention here was, that that dynamic view describes the API only, so only couple of reqs are linked here

github-project-automation Bot added this to TIM - Time FT Aug 25, 2026

github-project-automation Bot moved this to In Progress in TIM - Time FT Aug 25, 2026

lavrovvalera had a problem deploying to workflow-approval August 25, 2026 09:25 — with GitHub Actions Error

lavrovvalera changed the title ~~Update the~~ Update the Feature design Aug 25, 2026

lavrovvalera had a problem deploying to workflow-approval August 25, 2026 10:00 — with GitHub Actions Error

lavrovvalera mentioned this pull request Aug 25, 2026

Update the Time Architecture eclipse-score/score#3200

Draft

lavrovvalera had a problem deploying to workflow-approval August 25, 2026 10:08 — with GitHub Actions Error

lavrovvalera force-pushed the vala_feat_arch branch from 8c9cfdd to 6140565 Compare August 25, 2026 10:59

lavrovvalera had a problem deploying to workflow-approval August 25, 2026 10:59 — with GitHub Actions Error

BjoernAtBosch reviewed Aug 25, 2026

View reviewed changes

lavrovvalera had a problem deploying to workflow-approval August 26, 2026 11:48 — with GitHub Actions Error

lavrovvalera added 2 commits August 26, 2026 14:00

Add Time feature architecture

68683b4

- Add Time Feature Architecture to docs/features/architecture/ - Add docs/conf.py with required_in_id for path validation

Fix review comments

d4758f0

lavrovvalera force-pushed the vala_feat_arch branch from e396626 to d4758f0 Compare August 26, 2026 12:00

lavrovvalera had a problem deploying to workflow-approval August 26, 2026 12:01 — with GitHub Actions Error

BjoernAtBosch reviewed Aug 26, 2026

View reviewed changes

Comment thread docs/features/architecture/_assets/static_arch.puml Outdated

Comment thread docs/features/architecture/_assets/vehicle_time_read_flow.puml Outdated

BjoernAtBosch mentioned this pull request Aug 26, 2026

Restructure documentation to meet S-CORE conventions #123

Closed

Fix review comments

e79a673

lavrovvalera had a problem deploying to workflow-approval August 27, 2026 13:35 — with GitHub Actions Error

Add the feat_arc_dyn to wrap synamic behaiviour

baaeae8

lavrovvalera requested a deployment to workflow-approval August 27, 2026 15:47 — with GitHub Actions Waiting

BjoernAtBosch approved these changes Aug 28, 2026

View reviewed changes

ryan-steel reviewed Sep 2, 2026

View reviewed changes

Uh oh!

Conversation

lavrovvalera commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BjoernAtBosch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BjoernAtBosch left a comment

Choose a reason for hiding this comment

Uh oh!

ryan-steel Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

ryan-steel Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

lavrovvalera Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

ryan-steel Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

lavrovvalera Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lavrovvalera commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading