Skip to content

Stopped apt-get update being the gate it was never meant to be #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdesbiens merged 1 commit into from
Sep 9, 2026
Merged

Stopped apt-get update being the gate it was never meant to be #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,31 @@ retry() {
return 1
}

retry sudo "${TIMEOUT[@]}" apt-get "${APT_OPTIONS[@]}" update
# THE UPDATE IS NOT THE GATE, AND IT MUST NOT BE. apt-get update fails if ANY
# configured repository serves a bad index, including ones this project does
# not use. On a GitHub runner the image carries Google's and Microsoft's
# repositories, and a Hash Sum mismatch from Google's -- their CDN caught
# mid-publish, index and Release file eight hours apart -- failed this script
# three attempts running and turned a release build red over a browser nobody
# was installing.
#
# The alternative of disabling third-party sources before updating is wrong
# here: this script also runs on a contributor's own machine, where silently
# rewriting their apt configuration would be a far worse thing to do than
# tolerating a stale index.
#
# So a failed update WARNS and the install below is the gate. Nothing is
# weakened by that: apt-get install still fails hard on a package it cannot
# find, so an archive that is genuinely unreachable still stops the script --
# one step later, and saying which package it could not get.
if ! retry sudo "${TIMEOUT[@]}" apt-get "${APT_OPTIONS[@]}" update; then
echo ""
echo "install.sh: apt-get update did not fully succeed."
echo "install.sh: continuing, because a repository this project does not"
echo "install.sh: use can fail an update. The install below is the real"
echo "install.sh: gate and fails if any package needed is unavailable."
echo ""
fi
# gcc-14 and g++-14 EXPLICITLY, alongside build-essential.
#
# build-essential on ubuntu-24.04 is GCC 13, and GCC 14 is the compiler the
Expand Down