Reduce duplicate cart reads on checkout shipping mutation paths - #464
Merged
Conversation
The deletedCount==0 path now keeps this value as the authoritative total instead of always re-reading, matching the guards on the other two reads.
field123
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #463
Summary
Reduces duplicate cart reads after shipping-related cart mutations while preserving
the existing server-authoritative payment flow.
Changes:
applyShippingSelection/setCartShippingLinein/payandupdate-sessioninstead of performing an additionalgetACartonlyto refresh totals.
clearCartShippingLinereportdeletedCount; on non-shipping/pay,skip the post-clear total fetch when no managed
__ep_shippinglines wereremoved, while still refreshing totals after an actual cart mutation.
#436 stale
__ep_shippingcleanup.No changes to:
Test plan
pay,security-regression,update-session,and
set-shipping-line__ep_shippingskips unnecessary post-clear total fetch__ep_shippingclears the line, refreshes totals,and preserves correct free/paid behavior