Fix scheduled room deletion timestamp display - #599
Open
AyobamiH wants to merge 2 commits into
Open
Conversation
AyobamiH
force-pushed
the
fix/scheduled-room-deletion-timestamp-227
branch
from
August 24, 2026 16:52
45e6d69 to
9eafb08
Compare
AyobamiH
marked this pull request as ready for review
August 24, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #227
Synapse gives timestamp_ms different semantics depending on scheduled-task status. While a task is scheduled, it is the future launch time. Element Admin currently renders both scheduled and active as “in progress since”, which makes a correctly future-dated scheduled deletion appear wrong.
This change renders scheduled separately, showing the localized launch date/time while leaving active, complete, and failed states unchanged. No timezone arithmetic is introduced.
I traced the behaviour to ScheduledTaskDisplay, verified the Synapse API contract, confirmed #385 is a duplicate of #227, checked for an existing PR before starting, and discussed the proposed direction in #ess-community:element.io before submitting.