Fix App memory leak - #608
Open
lenemter wants to merge 1 commit into
Open
Conversation
leolost2605
requested changes
Aug 23, 2026
leolost2605
left a comment
Member
There was a problem hiding this comment.
Could we use GLib.HashTable.take ()? Would make it just a little bit more readable IMO
Member
Author
|
@leolost2605
|
leolost2605
approved these changes
Aug 23, 2026
leolost2605
left a comment
Member
There was a problem hiding this comment.
Too bad, I thought since it's a vala method take would take care of the key or just do it differently altogether but ig not :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was in
GLib.HashTable.steal_extendeduse. The whole point ofsteal*methods is to transfer ownership of the objects without calling destroy functions. But since the second argument (stolen key) was null, the ownership was never transferred and destroy function (unrefif this case) was never called, which lead to memory leak.Instead of dealing with convoluted method, just use
@getandremove.