Introduce AnimatableWidget and use Adw.PropertyAnimationTarget - #609
Merged
Conversation
Member
Author
|
@leolost2605 I removed cleanup here. Let me know what you think about it and whether it's the direction you want to go |
lenemter
force-pushed
the
lenemter/use-property-animations
branch
from
August 24, 2026 17:31
dc4e691 to
db9acbc
Compare
leolost2605
approved these changes
Aug 25, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
This is really cool!
Tbh when I suggested this I thought the adw callback target would always pass the widget to the callback so that we could just use static functions but ig I was wrong 😬
Still, I think the way you did it in this PR is actually really clean and I would prefer it over having the cleanup if it's fine with you :)
Member
|
This is way cool to make it so you can just do a property animation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes memory leak in BaseItem/Launcher by removing
BaseItem.cleanup ()method altogether. Adw.Animation takes a weak reference, not strong one, so the memory leak reason was theAdw.CallbackAnimationTargets we use.Instead of using
Adw.CallbackAnimationTargetuseAdw.PropertyAnimationTargetvia customAnimatableWidgetclass that implements translation-x/y and scale propertiesCloses #605
Closes #607