Conversation
Because storage devices typically advertise their capacities in "base 1000" rather than "base 1024". A disk advertised as having 2 TB capacity previously showed as 1.8 TiB in the system view. With this diff it now shows as 2 TB which is what a user would expect to see.
It usually shows larger usage because free space (which is used to calculate usage) is counted for only mounted volumes and won't work for multiple partitions with only some mounted.
Not really useful info after removal of free/used info? Also, edge case of it potentially showing "not mounted" if free space really is zero.
|
Could you add before-after screenshots please ? |
|
I find it strange to remove information that can be useful to some. I am not sure most people use partitions, so it may have been pretty accurate for common use cases. |
|
Yeah I'm -1 on removing usage info. Why even show disks at all if you're not showing the usage? |
|
Yup seems about right, I've reverted those commits to bring back the usage bar, I'll open another PR to collect/show better usage shortly. |
|
Actually, I'll just make those changes in this PR itself... |
|
This is now what the before-after looks like after commit ec5d71e IMO a little less misleading for both users like me (with many partitions) and most other users who usually either only dual-boot with Windows (so far fewer partitions) or run elementary OS by itself on bare metal or in a VM: |



Before and after screenshots: #547 (comment)
Revised before and after screenshots after review feedback and commit ec5d71e: #547 (comment)