Skip to content

Some storage info cleanup in system view - #547

Open
vjr wants to merge 8 commits into
mainfrom
vishal/disk-size
Open

vjr wants to merge 8 commits into
mainfrom
vishal/disk-size

Conversation

@vjr

@vjr vjr commented Sep 14, 2026

Copy link
Copy Markdown
Member
  • Remove IEC_UNITS flag to show more relevant storage capacity info.
  • Remove showing of used space info which is likely incorrect especially for multiple partitions with only some mounted.
  • Remove "not mounted" label altogether now that free/used info is gone, was it really useful?

Before and after screenshots: #547 (comment)

Revised before and after screenshots after review feedback and commit ec5d71e: #547 (comment)

vjr added 3 commits September 14, 2026 17:48
Because storage devices typically advertise their capacities in "base 1000" rather than "base 1024".
A disk advertised as having 2 TB capacity previously showed as 1.8 TiB in the system view.
With this diff it now shows as 2 TB which is what a user would expect to see.
It usually shows larger usage because free space (which is used to calculate usage) is counted for only mounted volumes and won't work for multiple partitions with only some mounted.
Not really useful info after removal of free/used info?
Also, edge case of it potentially showing "not mounted" if free space really is zero.
@vjr vjr self-assigned this Sep 14, 2026
@vjr
vjr requested review from a team, danirabbit and stsdc September 14, 2026 12:43
@flodavid

Copy link
Copy Markdown

Could you add before-after screenshots please ?

@vjr

vjr commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Could you add before-after screenshots please ?

BEFORE:

monitor-storage-before

AFTER:

monitor-storage-after

@flodavid

flodavid commented Sep 20, 2026

Copy link
Copy Markdown

I find it strange to remove information that can be useful to some. I am not sure most people use partitions, so it may have been pretty accurate for common use cases.
A more involved option would be to also show partitions, but it would require some designing . I am not sure what is the best solution in the meantime (and that is if it gets ever done), but maybe keep the size information if the biggest partition takes like 95% of the total storage space and hide it otherwise ?

@danirabbit

Copy link
Copy Markdown
Member

Yeah I'm -1 on removing usage info. Why even show disks at all if you're not showing the usage?

@vjr

vjr commented Sep 20, 2026

Copy link
Copy Markdown
Member Author

Yup seems about right, I've reverted those commits to bring back the usage bar, I'll open another PR to collect/show better usage shortly.

@vjr

vjr commented Sep 20, 2026

Copy link
Copy Markdown
Member Author

Actually, I'll just make those changes in this PR itself...

@vjr

vjr commented Sep 20, 2026

Copy link
Copy Markdown
Member Author

This is now what the before-after looks like after commit ec5d71e IMO a little less misleading for both users like me (with many partitions) and most other users who usually either only dual-boot with Windows (so far fewer partitions) or run elementary OS by itself on bare metal or in a VM:

BEFORE:
monitor-storage-before

AFTER:
monitor-storage-mounted-used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants