Improve :file info type in stacktrace entries - #15892
Open
lukaszsamson wants to merge 2 commits into
Open
lukaszsamson wants to merge 2 commits into
lukaszsamson wants to merge 2 commits into
Conversation
Follow up to elixir-lang#15798
josevalim
reviewed
Sep 13, 2026
| chardata = | ||
| binary() | ||
| |> opt_union(empty_list()) | ||
| |> opt_union(non_empty_list(term(), opt_union(binary(), empty_list()))) |
Member
There was a problem hiding this comment.
This is accepting any term in the list. We probably need to define this as a recursive type.
Contributor
Author
There was a problem hiding this comment.
Are recursive types mature enough to use them?
Member
There was a problem hiding this comment.
yes, I'd say now is the perfect time to start!
Introduce scope param to recursive Fix to_quoted on recursive types
Contributor
Author
|
@josevalim recursive types would spin endlessly on to_quoted. I added a clause handling that. I also added |
Member
|
Oh, I suppose we need to add pretty printing of recursive types first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR further improves type of file info in stacktrace by allowing nested chardata
Follow up to #15798
AssistedBy: Claude Fable 5.1