Skip to content

Optimize path splitting #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Aug 26, 2026
+3 −5
Merged

Optimize path splitting #1323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/plug/adapters/test/conn.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,7 @@ defmodule Plug.Adapters.Test.Conn do
defp split_path(nil), do: []

defp split_path(path) do
segments = :binary.split(path, "/", [:global])
for segment <- segments, segment != "", do: segment
:binary.split(path, "/", [:global, :trim_all])
end

@already_sent {:plug_conn, :sent}
Expand Down
3 changes: 1 addition & 2 deletions lib/plug/conn/adapter.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ defmodule Plug.Conn.Adapter do
end

defp split_path(path) do
segments = :binary.split(path, "/", [:global])
for segment <- segments, segment != "", do: segment
:binary.split(path, "/", [:global, :trim_all])
end

@doc """
Expand Down
2 changes: 1 addition & 1 deletion lib/plug/router/utils.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ defmodule Plug.Router.Utils do

"""
def split(bin) do
for segment <- String.split(bin, "/"), segment != "", do: segment
:binary.split(bin, "/", [:global, :trim_all])
end

@deprecated "Use Plug.forward/4 instead"
Expand Down