Fix unique_for_<range> validation on partial serializer updates (refs #6341) - #10040
Open
VimalN2005 wants to merge 2 commits into
Open
Fix unique_for_<range> validation on partial serializer updates (refs #6341)#10040VimalN2005 wants to merge 2 commits into
VimalN2005 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting a code change, please review our contributing guidelines.
Description
Fixes #6341.
BaseUniqueForValidator(and subclassesUniqueForDateValidator,UniqueForMonthValidator, andUniqueForYearValidator) previously raised a required fieldValidationErroron partial updates (partial=True) wheneverfieldordate_fieldwas omitted from the request payload.Furthermore, if only one of the fields was provided in the partial update, the validator failed because the missing field was not resolved from
serializer.instance.Changes
BaseUniqueForValidator.enforce_required_fieldsto acceptserializer=Noneand bypass requirement checks when updating an existinginstance, matching the design ofUniqueTogetherValidator.BaseUniqueForValidator.__call__to:attrs.serializer.instancewhen only one field is provided.tests/test_validators.pycovering:UniqueForMonthValidatorandUniqueForYearValidatorparity.HiddenFieldwith date constraints.