Add explicit contexts and OAuth-backed Jira Assets - #74
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request transitions the Jira Assets (CMDB) client from Basic authentication to OAuth 2.0, adding the necessary scopes and updating setup instructions. It also introduces a global --context flag and ATLASSIAN_CONTEXT environment variable to allow process-local host overrides without mutating the shared configuration file. Additionally, a new assets object subcommand is added to retrieve and display a specific Assets object and its attributes. Feedback on the new subcommand suggests explicitly checking for nil attribute values to prevent printing the literal string "" in the CLI output.
|
/gemini review |
|
🔏 Readiness attested — the Readiness summaryPR Readiness Check (#74, 76dd99e) |
Merging this branch changes the coverage (1 decrease, 5 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
1 participant
Summary
--context <alias-or-hostname>/ATLASSIAN_CONTEXTrouting without mutatingcurrent_hostjira assets object <id>with attribute-preserving JSON output and expose token scopes inauth status --jsonSupports the Assets-field migration tracked in NX-16111.
Verification
goimports -w .golangci-lint run(0 issues)go test -vacross all package groupsgo test ./...Release
After merge, tag
v1.13.0; the tag-triggered GoReleaser workflow publishes binaries and updates the Homebrew tap.