Update tcl91 CI job to Tcl 9.1b0 and fail testsuite fast on modulecmd crash - #690
Merged
Conversation
Assisted-by: Claude:claude-fable-5 Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
When a spawned modulecmd process dies from a signal, closing its output channel raises a CHILDKILLED error that escapes the readpipe event handler as a background error. Without a bgerror procedure defined under runtest, the endpipe variable is left unset and the vwait call in modulecmd_xxx_ hangs forever, freezing the testsuite run until the CI job 6-hour timeout. Define a bgerror procedure that reports the caught error and releases the ongoing command wait, so such a crash makes the related test fail right away. Assisted-by: Claude:claude-fable-5 Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the tcl91 CI job to build Tcl 9.1b0, which fixes the interpreter panic raised by 9.1a1 when the init.tcl script found in the
TCL_LIBRARYenvironment variable fails to evaluate.Also define a
bgerrorprocedure in the testsuite configuration: when a spawnedmodulecmdprocess dies from a signal, closing its output channel raises aCHILDKILLEDerror that escapes thereadpipeevent handler as a background error. Without abgerrorprocedure defined underruntest, theendpipevariable is left unset and thevwaitcall hangs forever, freezing the testsuite run until the CI job 6-hour timeout — as observed while debugging the tcl91 job hang on PR #689. With this procedure, such a crash is reported and the related test fails right away.