Fix issues - #2628
Open
Badiboy wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changed threaded and non-threaded polling guards are bypassed by the new regression test.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes urllib3 multipart formatter compatibility and corrects polling log-level comparisons.
Changes:
- Supports current and legacy urllib3 formatter names.
- Corrects synchronous and asynchronous polling log filtering.
- Adds regression tests for formatter selection and infinity polling.
File summaries
| File | Description |
|---|---|
telebot/apihelper.py |
Selects the available urllib3 multipart formatter. |
telebot/__init__.py |
Corrects synchronous polling log-level guards. |
telebot/async_telebot.py |
Corrects asynchronous polling log-level guards. |
tests/test_apihelper_95.py |
Tests formatter compatibility and patching. |
tests/test_telebot.py |
Tests synchronous infinity-polling logging. |
tests/test_async_telebot.py |
Tests asynchronous infinity-polling logging. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix urllib3.fields.format_header_param issue (https://github.com/eter…nnoir/pyTelegramBotAPI/issues/2619).
Fix logging issue (#2627)
Describe your tests
Regression tests generated.