Fix replacement of named provider injections - #982
Open
be-student wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #974.
add_kwargs()retained duplicate named injections. An older async dependency could finish after its replacement and overwrite the result; with extra call-time kwargs, the older entry could win immediately. Merge named injections when registering them so the latest value wins and superseded providers are never invoked. Apply the same rule to attribute injection andDictmapping/keyword inputs.Validation: 25 regression cases fail before the fix; all 35 focused cases pass afterward, including async replacements and call-time overrides. Full suite: 1,412 passed, 2 skipped before adding the final 10 focused controls. Cython limited-API build, flake8, pydocstyle, and strict mypy pass on Python 3.12/macOS. Other Python/platform combinations are left to CI.