refactor(edmonds-karp): drop two unsafe Send impls the compiler already provides - #820
Open
tachsin wants to merge 1 commit into
Open
refactor(edmonds-karp): drop two unsafe Send impls the compiler already provides#820tachsin wants to merge 1 commit into
tachsin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #817.
Removes both
unsafe impl Send. Every field ofSparseCapacityandDenseCapacityisSendwheneverCis, so the compiler derives the same impl with the same bound, and the crate is left with nounsafein this file at all.Adds a compile-time assertion in its place:
so the property is still verified, and a future field that is not
Sendfails the build instead of being silently promised away by the hand-written impl.Checking
Purely a removal; no behaviour changes. 291 tests pass, clippy and rustfmt clean.
This touches the same file as #819 but not the same lines; I checked they merge in either order.