Skip to content

fix(flake): Make the flake actually run - #252

Open
RasmusRendal wants to merge 1 commit into
masterfrom
RasmusRendal/working-flake
Open

fix(flake): Make the flake actually run#252
RasmusRendal wants to merge 1 commit into
masterfrom
RasmusRendal/working-flake

Conversation

@RasmusRendal

@RasmusRendal RasmusRendal commented Apr 16, 2026

Copy link
Copy Markdown

In order to make the Nix flake work for Synapse development:

  • Bump flake.lock
  • Bump devenv
  • Bump Rust to 1.89
  • Bump Perl

I also removed the built-in prompt. I have my own prompt, which I much prefer.


Note

Low Risk
Changes affect only local Nix/devenv development setup, not production Synapse runtime or application code.

Overview
Updates the Synapse Nix flake so nix develop / devenv up work again with current tooling.

devenv is bumped from v0.6.3 to v2.0.6, with a full flake.lock refresh (nixpkgs, rust-overlay, crate2nix, git-hooks, and related inputs). Synapse startup hooks now use process.manager.before instead of process.before, matching devenv 2’s process manager API.

The dev shell pins Rust stable 1.89.0 (was 1.82.0) and switches SyTest’s Perl module path from perl538Packages to perl5Packages. Built-in Starship prompt integration is removed (starship.enable deleted).

Reviewed by Cursor Bugbot for commit ee3f538. Bugbot is set up for automated code reviews on this repo. Configure here.

@RasmusRendal
RasmusRendal requested a review from a team as a code owner April 16, 2026 16:52
@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.86%. Comparing base (570ad41) to head (ee3f538).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   80.87%   80.86%   -0.01%     
==========================================
  Files         504      504              
  Lines       72717    72717              
  Branches    10973    10973              
==========================================
- Hits        58807    58806       -1     
- Misses      10621    10622       +1     
  Partials     3289     3289              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570ad41...ee3f538. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RasmusRendal
RasmusRendal force-pushed the RasmusRendal/working-flake branch from c9cf3df to 40ddcc0 Compare September 3, 2026 07:28
In order to make the Nix flake work for Synapse development:
 - Bump flake.lock
 - Bump devenv
 - Bump Rust to 1.89
 - Bump Perl
@RasmusRendal
RasmusRendal force-pushed the RasmusRendal/working-flake branch from 40ddcc0 to ee3f538 Compare September 3, 2026 07:30

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee3f538. Configure here.

Comment thread flake.nix
# * ensures a directory containing two additional homeserver config files exists;
# one to configure using the development environment's PostgreSQL as the
# database backend and another for enabling Redis support.
process.before = ''

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before hook skipped by native manager

High Severity

Issue: process.manager.before does not run under devenv 2.0.6's default native process manager, so devenv up skips homeserver config generation and Synapse cannot start.

Fix: Use a devenv task that runs before processes, or set process.manager.implementation = "process-compose".

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ee3f538. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant