🐛 Discover routes from imported custom APIRouter instances - #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217
This PR fixes a bug where the Path Operation Explorer could find routes decorated on a router instantiated from an imported
APIRoutersubclass, but it could not recognize the router assignment itself. This prevented the router node, and therefore its routes, from being added to the tree view.With this change, the analyzer records top-level router candidates even when their constructors are imported and cannot be recognized locally. When the resolver follows a module-qualified reference, it can use the corresponding router assignment to construct the missing router node.
See the
custom-routerfixture as an example.