Fix custom registry assignment in model_config and inheritance - #2090
Open
CAOShurong wants to merge 1 commit into
Open
Fix custom registry assignment in model_config and inheritance#2090CAOShurong wants to merge 1 commit into
CAOShurong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where configuring a custom SQLAlchemy
registrystoredconfig_tableintomodel_config["registry"]instead ofconfig_registry, and ensures that concrete table models subclassing a custom base model are properly mapped.Problem
In
SQLModelMetaclass.__new__:new_cls.model_config["registry"]was assignedconfig_table(which isUndefinedor abool), rather than the actualconfig_registryobject.Furthermore, because
model_configis inherited by subclasses in Pydantic v2, readingget_config("registry")from inheritedmodel_configwould trigger the registry block on every subclass, unconditionally setting__abstract__ = Trueon concrete table classes inheriting from the custom base.Solution
registryvia class kwargs (kwargs.get("registry")) or explicitclass_dict["model_config"].new_cls.model_config["registry"] = config_registry.tests/test_main.pytesting custom base registry definition, table subclassing, mapper initialization, and DB session operations.