-
-
Notifications
You must be signed in to change notification settings - Fork 126
Add readme for h3 example #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,41 @@ | ||||||||||||||||||||||
| Fedify–H3 integration example | ||||||||||||||||||||||
| ============================= | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| This is a simple example of how to integrate Fedify into an [H3] | ||||||||||||||||||||||
| application. | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| [H3]: https://h3.unjs.io/ | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| Running the example | ||||||||||||||||||||||
| ------------------- | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| 1. Clone the repository: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ~~~~ sh | ||||||||||||||||||||||
| git clone https://github.com/fedify-dev/fedify.git | ||||||||||||||||||||||
| ~~~~ | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| 2. Move to the example folder: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ~~~~ sh | ||||||||||||||||||||||
| cd examples/h3 | ||||||||||||||||||||||
| ~~~~ | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| 3. Install dependencies: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ~~~~ sh | ||||||||||||||||||||||
| pnpm install | ||||||||||||||||||||||
| ~~~~ | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| 4. Start the server: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ~~~~ sh | ||||||||||||||||||||||
| deno serve -A index.ts | ||||||||||||||||||||||
| ~~~~ | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| 5. Look up the actor URL: | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| ~~~~ | ||||||||||||||||||||||
| http://localhost:8000/users/{identifier} | ||||||||||||||||||||||
| ~~~~ | ||||||||||||||||||||||
|
Comment on lines
+37
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Specify a language for the actor URL code fence. Add a language identifier to the opening fence. This resolves the reported MD040 warning. Proposed fix- ~~~~
+ ~~~~ text
http://localhost:8000/users/{identifier}
~~~~📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.23.2)[warning] 39-39: Fenced code blocks should have a language specified (MD040, fenced-code-language) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Enter the cloned repository before changing to the example directory.
Line 16 creates a
fedifydirectory, but Line 22 runs from the original directory. Change Line 22 tocd fedify/examples/h3, or addcd fedifybefore it.Proposed fix
2. Move to the example folder: ~~~~ sh - cd examples/h3 + cd fedify/examples/h3 ~~~~📝 Committable suggestion
🤖 Prompt for AI Agents